Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow mix content in title field for map content #905

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Mar 21, 2024

Summary

Allow mix content in the Title field on Map Content.

Changes:

  • reducing the margin for the tags to allow better alignment with simple content
  • made a special case for the title field tagify initialization
  • before the mix content, the tags are saved as a list and transformed from [[{"value":"[#item_title]"}], [{"value":"[#item_date]"}]] to [#item_title], [#item_date]. With mix content enabled, the data is saved like this: Title "[[{"value":"[#item_title]"}]]" on [[{"value":"[#item_date]"}]]; a clean is done with regex to get Title "[#item_title]" on [#item_date]

Will affect visual aspect of the product

NO

Screenshots

2024-03-21_14-20-44.mp4

Test instructions

  • Create a new import
  • In the Title Post field on Map Content, try to add a combination of text and tags ( do no use closing with <> as it will be filtered by the HTML filter )
  • Run the imported and check the title.

Check before Pull Request is ready:

Closes #904

@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Mar 21, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Mar 21, 2024
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Mar 21, 2024
@pirate-bot
Copy link
Contributor

pirate-bot commented Mar 21, 2024

Plugin build for 1146c23 is ready 🛎️!

@Soare-Robert-Daniel Soare-Robert-Daniel linked an issue Mar 21, 2024 that may be closed by this pull request
@vytisbulkevicius vytisbulkevicius merged commit 63a31ea into development Mar 28, 2024
13 checks passed
@vytisbulkevicius vytisbulkevicius deleted the fix/title-with-text-before-tag branch March 28, 2024 11:26
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 4.4.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Being able to add text before the title Tag
4 participants