Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feeds marked invalid #856

Closed
AndreeaCristinaRadacina opened this issue Jan 15, 2024 · 3 comments · Fixed by #858
Closed

Feeds marked invalid #856

AndreeaCristinaRadacina opened this issue Jan 15, 2024 · 3 comments · Fixed by #858
Assignees
@girishpanchal30
Labels
bug This label could be used to identify issues that are caused by a defect in the product. customer report Indicates the request came from a customer. Priority-Medium Expected resolution time - up to 1 month. released Indicate that an issue has been resolved and released in a particular version of the product.

Comments

@AndreeaCristinaRadacina
Copy link

Description

A user reported that several feeds are being marked as invalid.

Ref: https://wordpress.org/support/topic/all-my-feeds-marked-invalid-on-update/#post-17344845

Step-by-step reproduction instructions

  1. Go to Feedzy > Feed Categories
  2. Create a new category
  3. Paste the following feed sources: https://aseannewstoday.com/countries/myanmar/feed/, https://www.frontiermyanmar.net/feed/, https://www.rfa.org/english/news/burma_news/rss2.xml, https://www.aljazeera.com/xml/rss/all.xml, https://www.eastasiaforum.org/category/countries/myanmar/feed/, https://www.thechindwin.com/feed/
  4. Click on update

Screenshots, screen recording, code snippet or Help Scout ticket

https://vertis.d.pr/i/Kmj661

If you try to copy one of the invalid feeds and paste it inside the validator, you will see it appends http://%20 in front of the URL. If you eliminate it and only paste the feed URL, it becomes valid.
image

Environment info

No response

Is the issue you are reporting a regression

No
@AndreeaCristinaRadacina AndreeaCristinaRadacina added the bug This label could be used to identify issues that are caused by a defect in the product. label Jan 15, 2024
@pirate-bot pirate-bot added the customer report Indicates the request came from a customer. label Jan 15, 2024
@vytisbulkevicius
Copy link
Contributor

Additional information here:

This issue happens when there is space between a semicomma that separates feeds.

So for example if you add all the feeds to a category without a space:
https://aseannewstoday.com/countries/myanmar/feed/,https://www.frontiermyanmar.net/feed/,https://www.rfa.org/english/news/burma_news/rss2.xml,https://www.aljazeera.com/xml/rss/all.xml,https://www.eastasiaforum.org/category/countries/myanmar/feed/,https://www.thechindwin.com/feed/

It works fine.

If you add them with spaces:
https://aseannewstoday.com/countries/myanmar/feed/, https://www.frontiermyanmar.net/feed/, https://www.rfa.org/english/news/burma_news/rss2.xml, https://www.aljazeera.com/xml/rss/all.xml, https://www.eastasiaforum.org/category/countries/myanmar/feed/, https://www.thechindwin.com/feed/

They are removed as invalid.

So it's not related to feeds in use but to space.

Also, when they are successfully saved, even when added without spaces we add spaces after saving, so next time you click update they are removed as invalid.

@vytisbulkevicius vytisbulkevicius added the Priority-Medium Expected resolution time - up to 1 month. label Jan 16, 2024
girishpanchal30 added a commit that referenced this issue Jan 19, 2024
@girishpanchal30
Fix invalid feed issue with white space #856
0bc0b68
@girishpanchal30 girishpanchal30 mentioned this issue Jan 19, 2024
Merged
@girishpanchal30 girishpanchal30 linked a pull request Jan 19, 2024 that will close this issue
Fixed invalid feed issue with white space #858
Merged
@girishpanchal30
Copy link
Contributor

Hey @AndreeaCristinaRadacina,

I've reviewed this issue and fixed it this PR #858

cc @vytisbulkevicius

Thanks

@pirate-bot
Copy link
Contributor

🎉 This issue has been resolved in version 4.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@girishpanchal30 girishpanchal30

Labels
bug This label could be used to identify issues that are caused by a defect in the product. customer report Indicates the request came from a customer. Priority-Medium Expected resolution time - up to 1 month. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed invalid feed issue with white space Codeinwp/feedzy-rss-feeds
4 participants
@vytisbulkevicius @pirate-bot @girishpanchal30 @AndreeaCristinaRadacina