Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress tests failing #798

Closed
vytisbulkevicius opened this issue Sep 26, 2023 · 3 comments · Fixed by #799 or #804
Closed

Cypress tests failing #798

vytisbulkevicius opened this issue Sep 26, 2023 · 3 comments · Fixed by #799 or #804
Assignees
Labels
bug This label could be used to identify issues that are caused by a defect in the product.

Comments

@vytisbulkevicius
Copy link
Contributor

Description

@girishpanchal30 we have Cypress tests failing, for example - https://github.com/Codeinwp/feedzy-rss-feeds/actions/runs/6294733971/job/17086992313#step:8:91

We had this issue on another products, for example here - Codeinwp/templates-patterns-collection#282

Also here - Codeinwp/optimole-wp#674

So it caused some issues with releases on other products that's why we need to make sure we get it fixed. The solution requires upgrade for cypress.

Step-by-step reproduction instructions

Running job like - https://github.com/Codeinwp/feedzy-rss-feeds/actions/runs/6294733971/job/17086992313#step:8:91

Screenshots, screen recording, code snippet or Help Scout ticket

No response

Environment info

No response

Is the issue you are reporting a regression

No

@vytisbulkevicius vytisbulkevicius added the bug This label could be used to identify issues that are caused by a defect in the product. label Sep 26, 2023
girishpanchal30 added a commit that referenced this issue Sep 28, 2023
girishpanchal30 added a commit that referenced this issue Sep 28, 2023
girishpanchal30 added a commit that referenced this issue Sep 28, 2023
@girishpanchal30 girishpanchal30 linked a pull request Sep 28, 2023 that will close this issue
@girishpanchal30
Copy link
Contributor

Hey @vytisbulkevicius,

I've reviewed the cypress issue and fixed it with the below PR, please check and merge it into the development branch

Free - #799
Pro - https://github.com/Codeinwp/feedzy-rss-feeds-pro/pull/607

Thanks

@vytisbulkevicius
Copy link
Contributor Author

vytisbulkevicius commented Sep 29, 2023

Hi @girishpanchal30 both are merged but I see this one failing the test - https://github.com/Codeinwp/feedzy-rss-feeds/actions/runs/6348551905

@girishpanchal30
Copy link
Contributor

@vytisbulkevicius Fixed, Please merge this PR - #800

@vytisbulkevicius vytisbulkevicius linked a pull request Oct 23, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This label could be used to identify issues that are caused by a defect in the product.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants