Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance issues related to the lazy endpoint #782

Closed
RohanSharma2598 opened this issue Jul 27, 2023 · 5 comments · Fixed by #783 or #784
Closed

Performance issues related to the lazy endpoint #782

RohanSharma2598 opened this issue Jul 27, 2023 · 5 comments · Fixed by #783 or #784
Assignees
Labels
bug This label could be used to identify issues that are caused by a defect in the product. customer report Indicates the request came from a customer. released Indicate that an issue has been resolved and released in a particular version of the product.

Comments

@RohanSharma2598
Copy link

Description

This is the Question from the customer that we are not sure how to approach or replicate so I am asking here:

We've been working through some issues with our site with our host, and one of the things we noticed is the request /wp-json/feedzy/v1/lazy is getting a lot of requests on our site. It actually was the top one by far. We use feedzy pretty extensively throughout our site to pull in feeds from our news site, commonthread.antioch.edu, so we don't really want to navigate away from your plugin. Are there steps we can put in place to minimize uncached server requests in regards to feedzy? We are fine with not having real time feeds if we can cache it in some way. Thank you for any help you provide.

image

Step-by-step reproduction instructions

N/A

Screenshots, screen recording, code snippet or Help Scout ticket

Help Scout: https://secure.helpscout.net/conversation/2307431545/378418?folderId=212385

Environment info

No response

Is the issue you are reporting a regression

No

@RohanSharma2598 RohanSharma2598 added the bug This label could be used to identify issues that are caused by a defect in the product. label Jul 27, 2023
@pirate-bot pirate-bot added the customer report Indicates the request came from a customer. label Jul 27, 2023
@selul selul changed the title A Question from a Customer Performance issues related to the lazy endpoint Jul 28, 2023
@girishpanchal30 girishpanchal30 linked a pull request Jul 31, 2023 that will close this issue
@girishpanchal30
Copy link
Contributor

Hey @vytisbulkevicius,

After reviewing this issue, I discovered that the lazy endpoint still calls even when the lazy feed has a valid cache.
Now I've made some changes to avoid lazy API calling if the feed has a valid cache.

Please check with the attached PR and do let me know if found any issues.

Thanks

@irinelenache
Copy link

@girishpanchal30 Tried to test the fix but i couldn't find the data-has_valid_cache attribute, let me know if i didn't correctly understand this

You can check here:

https://fz-lazy-issue.vertisite.cloud/new-shortcode/
User: hiwawizeya3073
Password: 04PlCA7u8FLEtMh6THx5

girishpanchal30 added a commit that referenced this issue Aug 1, 2023
@girishpanchal30
Copy link
Contributor

@irinelenache It seems issue with transient key and now it fixed with latest commit.

@irinelenache
Copy link

@girishpanchal30 Now it works fine, thank you 👍

@vytisbulkevicius vytisbulkevicius linked a pull request Aug 3, 2023 that will close this issue
@pirate-bot
Copy link
Contributor

🎉 This issue has been resolved in version 4.2.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This label could be used to identify issues that are caused by a defect in the product. customer report Indicates the request came from a customer. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
4 participants