-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ft/climatemapped-improvements #991
Conversation
Signed-off-by: Kipruto <[email protected]>
Signed-off-by: Kipruto <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kelvinkipruto This doesn't run locally, I get this error
@koechkevin You have to login to the admin and add a URL in HURUmap settings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏽 ... not too sure about the code structure though.
apps/climatemappedafrica/src/payload/fields/HURUMapURL/index.js
Outdated
Show resolved
Hide resolved
apps/climatemappedafrica/src/payload/fields/HURUMapURL/index.js
Outdated
Show resolved
Hide resolved
apps/climatemappedafrica/src/payload/globals/HURUMap/Profile.js
Outdated
Show resolved
Hide resolved
apps/climatemappedafrica/src/components/Navigation/ExploreNavigation/index.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Kipruto <[email protected]>
I also see function parameters named |
Resolved @kilemensi |
Description
This PR makes several improvements to ClimateMapped
select
, we will always be sure about the value. This also improves the speed of the page by reducing API calls.Fixes #994 #995
Type of change
Screenshots
Checklist: