Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ERB/EJS Grammar #61

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

cengelbart39
Copy link
Contributor

@cengelbart39 cengelbart39 commented Oct 2, 2023

Description

Adds ERB/EJS grammar via tree-sitter-embedded-template.

Related Issues

Depending on the desire to add more languages to CELanguages, it could close this issue as well.

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

@cengelbart39
Copy link
Contributor Author

With the current implementation, there are highlighting issues with ERB and EJS.

For ERB, Ruby doesn't highlight properly (left ERB, right Ruby)
Screenshot_2023-09-24_at_9 42 34_AM

While HTML highlighting works, it isn't perfect either, with some closing tags not being highlighted
Screenshot_2023-09-24_at_9 43 09_AM

It's a similar case for EJS, with JavaScript not highlighting, while HTML highlighting is the same as ERB
(left EJS, right JS)
Screenshot_2023-09-24_at_9 43 23_AM

While I have mentioned this in the Discord, I felt I should include it here for anyone waiting on this PR to not be a draft anymore.

@cengelbart39
Copy link
Contributor Author

I updated the PR to keep up with changes to the package since created.

Between updates to CE, CEL, CETX, and CESE, the highlighting issue persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants