Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added VZNetworkBlockDeviceStorageDeviceAttachment #156

Merged
merged 6 commits into from
Oct 19, 2024

Conversation

saracen
Copy link
Contributor

@saracen saracen commented Jan 29, 2024

Further to #142, this adds VZNetworkBlockDeviceStorageDeviceAttachment support.

This PR lacks setting a delegate to monitor state changes to the attachment, mostly because I couldn't figure out the best way to integrate this and it would probably lead to a much larger PR. Hopefully that can be done in a follow-up.

I've updated the MacOS application to ease testing. You can serve an existing raw disk within the bundle directory with qemu-nbd:

qemu-nbd -k $(pwd)/source.sock -f raw -x export --cache=none disk.img

And then run:

./macOS -nbd-url "nbd+unix:///export?socket=source.sock"

The -install option also works well with this argument if you serve a disk created with qemu-img.

This is great news as it gives access to qemu's qcow2 format and linked disks functionality.

Relates to #143

@saracen
Copy link
Contributor Author

saracen commented Jan 30, 2024

@Code-Hex Is the failing CI something I should look into? I couldn't determine whether the cancelled operation was a CI failure, or whether the CI pipeline was externally cancelled.

#ifdef INCLUDE_TARGET_OSX_14
if (@available(macOS 14, *)) {
NSString *urlNSString = [NSString stringWithUTF8String:uri];
NSURL *url = [[NSURL alloc] initWithString:urlNSString];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also use NSURL URLWithString:urlNSString
With NSURL alloc, I believe url should be in a @autoreleasepool block or it will leak memory.
No idea if memory needs to be released with URLWithString, I don't know well enough how objc memory management works :-/

abiosoft and others added 4 commits October 4, 2024 12:53
@AkihiroSuda
Copy link
Collaborator

This repo doesn't seem actively maintained currently.

Would you be interested in submitting your PR to our fork? https://github.com/lima-vm/vz

@Code-Hex
Copy link
Owner

Code-Hex commented Oct 19, 2024

@AkihiroSuda I invited you to maintain this repo 🙏

@Code-Hex
Copy link
Owner

Code-Hex commented Oct 19, 2024

The job was not started because recent account payments have failed or your spending limit needs to be increased. Please check the 'Billing & plans' section in your settings.

@Code-Hex Code-Hex merged commit dc6221c into Code-Hex:main Oct 19, 2024
7 of 8 checks passed
@AkihiroSuda
Copy link
Collaborator

@AkihiroSuda I invited you to maintain this repo 🙏

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants