Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser window freezes when trying to upload large datasets. #69

Open
harrykeightley opened this issue Sep 5, 2023 · 1 comment
Open
Assignees
Labels
bug Something isn't working

Comments

@harrykeightley
Copy link
Contributor

Trying to upload the timit dataset through the datasets flow causes the browser to freeze up. Because we check to make sure all the files are in the right formats and paired properly, I think we keep them in memory...

We could try and just flat out remove mismatched/incorrect files on the server side and just have the user upload the files directly.

@harrykeightley harrykeightley added the bug Something isn't working label Sep 5, 2023
@harrykeightley harrykeightley self-assigned this Sep 5, 2023
@benfoley
Copy link
Contributor

benfoley commented Sep 5, 2023

At that scale of files, no user in their right mind is going to be sorting through files anyway. Let's go with taking all files that user uploads, and discarding anything that doesn't match. Can we still show a list of matching file names in a way that doesn't require the files to be held in memory?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants