Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.20.5+ request #30

Open
Daliawo opened this issue May 4, 2024 · 5 comments
Open

1.20.5+ request #30

Daliawo opened this issue May 4, 2024 · 5 comments

Comments

@Daliawo
Copy link

Daliawo commented May 4, 2024

I loved using this mod in my 1.20.4 world to create 20 minute days, and I want to update to 1.20.6. I've tried my best forking my own version of the mod for a 1.20.5 port, but I'm quite new to programming and I couldn't resolve errors in the java source files. Are there any plans for 1.20.5+ branches?

@arsel-5lvxa7b1
Copy link

@Daliawo @CmdrJane Hello, was reviewing my mods for 1.21 and this is my most wanted mod.

I've seen Daliawo's fork for 1.20.5, does it work properly? Idk what modding changes will be in 1.21 and also I've never been developing Minecraft mods. But I'm a software dev and can improve some parts after I'll learn about Minecraft modding. Particularly how to build JARs, it's been a long time I did Java.

My proposal is to coordinate and release versions for 1.20.5 - 1.21. If there's some stuff that needs fixing then we can work it out together. I'm thinking maybe this weekend. My timezone is UTC+5.

What do you think?

@arsel-5lvxa7b1
Copy link

arsel-5lvxa7b1 commented Jun 6, 2024

Also maybe 1.21 version can wait before actual release on 13th

Upd: Ah, I'm blind, saw that you had errors Daliawo, we can try fixing them

@Daliawo
Copy link
Author

Daliawo commented Jun 6, 2024

Great that you want to pick this up! This weekend would be difficult for me, but I can do next week on weekdays starting wednesdag or the weekend (I'm UTC+2). If we do it after the 13th, we can do the 1.21 version aswell.

The changes I made were mostly to the general gradle information (updating java from version 17-21, updating minecraft version from 1.20.4 to 1.20.5). ChatGPT guided me all the way, as I've never worked as a developer (this is my first github project), or in any language (besides R).

It ended up still giving me errors when I tried to compile the mod, and those errors were related to the java files. I was clueless as to what to do there, so I gave up. But I think someone who knows what they're doing could probably work it out.

@arsel-5lvxa7b1
Copy link

@Daliawo I think we can try sometime between 13th & 16th, if CmdrJane is unavailable or something else, we can try working it out in your own fork. I think putting out JARs in GitHub releases will be sufficient for now, we could add a link here after we do it so others can benefit too.

Weekdays I'm available around 15:00 to 19:00 UTC, weekends are free for now.

You can email me your Discord or Telegram if you have any of those, we can talk there.

@arsel-5lvxa7b1
Copy link

@CmdrJane @Daliawo
I think I fixed it, but we need to test it more, so I'll leave the release link for people to try out

https://github.com/arsel-5lvxa7b1/time-and-wind/releases/tag/taw-1.21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants