Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 100% CPU usage when CMAP connection is lost #129

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

susnux
Copy link

@susnux susnux commented Jun 24, 2021

When CMAP disconnects sbd results in 100% CPU usage.

This patch is currently used on SUSE, so upstreaming seem reasonable.

@knet-ci-bot
Copy link

Can one of the admins verify this patch?

@wenningerk
Copy link

test this please

@gao-yan
Copy link
Member

gao-yan commented Jun 24, 2021

I think this has been tracked with #80 . Of course it probably needs to be revisited when we get a chance ...

@wenningerk
Copy link

Yep it is tracked there and was supposed to be solved together with corosync-graceful-shutdown detection/handling.
At that time this wasn't easily possible but meanwhile corosync has added back an api that should allow easy detection of a graceful corosync shutdown.
So this should be revisited asap.
I'll take it on my list of urgent stuff ;-)

@wenningerk
Copy link

But let me keep this open for now as the patch here is a bit more elaborate and takes care of how inquisitor should react. But as said without graceful-corosync-shutdown detection this is of limited use anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants