Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scraping Data-Football in Past 10 Years #914

Closed
wants to merge 3 commits into from

Conversation

Soubeer
Copy link

@Soubeer Soubeer commented May 12, 2024

Description

Added .py for the code of data scraping on past 10 years of Football matches.(Convert into .ipynb for notebook version)
Includes comments for most code sections for better understanding of the viewer and future development.
All present inside football scraping folder

Resolves: [903]

Checklist

Before submitting this pull request, kindly verify that the ensuing checkpoints have been reached.

  • [✓] Have you adhered to the repository's defined coding convention rules?
  • Have you updated the 'documentation.md' file with the method/function documentation?
  • Have you sent a message along with the result or response?
  • Have you used the try-catch technique?
  • Has the method/class been added to the documentation (md file)?

Screenshots

image
beautiful soup as it is the easiest scraping library

image
Supports JSON if present in that form

image
Gets data for all the teams and converts into dataframe

image
Gets seasonal data and does the same with all

image
Provides categorical data at the end

I certify that I have carried out the relevant checks and provided the requisite screenshot for validation by submitting this pull request.
I appreciate your contribution.

Copy link
Member

@nikhil25803 nikhil25803 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Soubeer, I'll suggest you to check other modules like GitHub and IMDB and see how the modules are created.

We do not provide a Python script to do so, its a package that can be installed anywhere using pip. It must be implemented in classes and methods with proper namings.
Also do not include files like CSV or anything else except Python file.

@Soubeer
Copy link
Author

Soubeer commented May 15, 2024

@nikhil25803 I'm sorry, I could not find good sites on how to create modules. I understand the task and I saw that having the script as another file in the workspace can allow use for it for football scraping. I am not sure on how to create the module for it at the moment,

@nikhil25803 nikhil25803 closed this Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants