Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[client-v2] Make compression dependencies as required #1859

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chernser
Copy link
Contributor

@chernser chernser commented Oct 9, 2024

Summary

Client uses compression by default, but related library dependencies are optional. It causes confusion because users have to add extra dependencies while library cannot work without it without adjustments.
This PR fixes:

  • compression dependencies are required.
  • apache http client dependencies are cleaned up
  • updated in examples

Currently dependencies look like:

productionRuntimeClasspath
+--- com.clickhouse:client-v2:0.7.0-SNAPSHOT
|    +--- com.clickhouse:clickhouse-client:0.7.0-SNAPSHOT
|    +--- com.clickhouse:clickhouse-data:0.7.0-SNAPSHOT
|    +--- org.slf4j:slf4j-api:2.0.7 -> 2.0.13
|    +--- org.apache.httpcomponents.client5:httpclient5:5.3.1
|    +--- org.lz4:lz4-pure-java:1.8.0
|    +--- org.apache.commons:commons-compress:1.27.1
|    +--- commons-codec:commons-codec:1.17.1 -> 1.16.1
|    +--- commons-io:commons-io:2.16.1
|    +--- org.apache.commons:commons-lang3:3.16.0 -> 3.14.0
|    +--- org.ow2.asm:asm:9.7
|    \--- com.fasterxml.jackson.core:jackson-core:2.17.2

Closes: #1805
Closes: #1853

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

Copy link

sonarcloud bot commented Oct 9, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant