Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[client-v2] fixed number conversion in reader #1856

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chernser
Copy link
Contributor

@chernser chernser commented Oct 8, 2024

Summary

This PR make it possible to read columns into wider type. It is not possible with current implementation.

Examples

  • column of int8 can be read as Byte, Short, ...
  • column of int16 can be read as Short, Integer. ... but it cannot be read as Byte because can potentially truncate data. In this case application is responsible to do proper conversion.

Closes: #1852

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

Copy link

sonarcloud bot commented Oct 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
64.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[client-v2] No conversion between number types (ex. short to int)
1 participant