Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mysql table size calculation #93

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

hoptical
Copy link

Regarding issue #92, I modified the table size calculation code in mysql-myisam and mysql folders.
I can't run the benchmark for the whole dataset hence I can't modify the final result number.

Please check and inform me in case of any needed changes.

@CLAassistant
Copy link

CLAassistant commented Mar 30, 2023

CLA assistant check
All committers have signed the CLA.

@alexey-milovidov
Copy link
Member

Looks good to me. It should also be applied for MariaDB and Infobright.

@hoptical
Copy link
Author

hoptical commented Apr 1, 2023

Looks good to me. It should also be applied for MariaDB and Infobright.

@alexey-milovidov Applied on MariaDB and Inforbright.

@alexey-milovidov
Copy link
Member

Ok, now we have to re-run the benchmarks...

@hoptical
Copy link
Author

hoptical commented Apr 3, 2023

@alexey-milovidov Unfortunately, I can't run the benchmarks.

@alexey-milovidov
Copy link
Member

No problem, we can do it.

@tinybit tinybit self-assigned this Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants