extend weighted_dss for FieldVector #2000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
juliasloan25
force-pushed
the
js/dss-fv
branch
3 times, most recently
from
7edba4c
to
70b8e9d
Compare
dennisYatunin
approved these changes
Sep 20, 2024
juliasloan25
force-pushed
the
js/dss-fv
branch
from
70b8e9d
to
c9734a7
Compare
juliasloan25
force-pushed
the
js/dss-fv
branch
from
c9734a7
to
526b2d3
Compare
juliasloan25
force-pushed
the
js/dss-fv
branch
from
526b2d3
to
a96619f
Compare
juliasloan25
force-pushed
the
js/dss-fv
branch
from
a96619f
to
9075268
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend
weighted_dss!to work for FieldVectors in addition to Fields.Needed for CliMA/ClimaCoupler.jl#959, and will also be useful for ClimaAtmos.
To Do
Code quality