Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

non-product upwinding #1367

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

non-product upwinding #1367

wants to merge 2 commits into from

Conversation

simonbyrne
Copy link
Member

Fixes #1125.

  • Code follows the style guidelines OR N/A.
  • Unit tests are included OR N/A.
  • Code is exercised in an integration test OR N/A.
  • Documentation has been added/updated OR N/A.

@simonbyrne simonbyrne marked this pull request as draft July 12, 2023 21:25
@simonbyrne
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jul 12, 2023
@bors
Try #1367:
dfce036
@bors
Copy link
Contributor

bors bot commented Jul 12, 2023

try

Build failed:

@simonbyrne
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jul 12, 2023
@bors
Try #1367:
f39b509
@bors
Copy link
Contributor

bors bot commented Jul 12, 2023

try

Build failed:

@simonbyrne
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jul 12, 2023
@bors
Try #1367:
5b1602d
@bors
Copy link
Contributor

bors bot commented Jul 12, 2023

try

Build failed:

@simonbyrne
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jul 13, 2023
@bors
Try #1367:
4f543b1
@bors
Copy link
Contributor

bors bot commented Jul 13, 2023

try

Build failed:

@simonbyrne
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jul 13, 2023
@bors
Try #1367:
ffa22e0
@bors
Copy link
Contributor

bors bot commented Jul 13, 2023

try

Build failed:

@simonbyrne
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jul 13, 2023
@bors
Try #1367:
291e6d0
@bors
Copy link
Contributor

bors bot commented Jul 13, 2023

try

Build failed:

@simonbyrne
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jul 13, 2023
@bors
Try #1367:
bcbbf47
@bors
Copy link
Contributor

bors bot commented Jul 13, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@simonbyrne
Copy link
Member Author

bors try

@simonbyrne
Copy link
Member Author

bors try-

@simonbyrne
Copy link
Member Author

bors try

@simonbyrne simonbyrne marked this pull request as ready for review July 13, 2023 23:20
bors bot added a commit that referenced this pull request Jul 14, 2023
@bors
Try #1367:
40a8b01
@bors
Copy link
Contributor

bors bot commented Jul 14, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

charleskawczynski
charleskawczynski reviewed Jul 14, 2023
View reviewed changes
Copy link
Member

@charleskawczynski charleskawczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there tests added for the new operator(s)? It's a bit hard to tell with the name changes squashed together. If not, maybe we can add them / convergence tests? Aside from that LGTM

@simonbyrne
Copy link
Member Author

Good point. I was relying on the implicit testing, but we should add some more

@simonbyrne simonbyrne force-pushed the sb/upwinding-revamp branch 2 times, most recently from 81187ca to 237fce1 Compare July 18, 2023 17:24
@simonbyrne
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jul 18, 2023
@bors
Try #1367:
fe956be
@bors
Copy link
Contributor

bors bot commented Jul 18, 2023

try

Build failed:

@simonbyrne
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jul 18, 2023
@bors
Try #1367:
335e07b
@bors
Copy link
Contributor

bors bot commented Jul 18, 2023

try

Build failed:

@simonbyrne simonbyrne closed this Jul 18, 2023
@simonbyrne simonbyrne reopened this Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charleskawczynski charleskawczynski charleskawczynski left review comments

@dennisYatunin dennisYatunin dennisYatunin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Non-product upwind reconstuction operators
3 participants
@simonbyrne @charleskawczynski @dennisYatunin