You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Our fill! method follows our copyto! pattern, which uses CartesianIndexing, which is suboptimal especially in the context of fill!, so, we should just forward all of our fill! methods to fill!(parent(data), val). Here's a local benchmark on an A100 at our target resolution:
julia>@benchmark CUDA.@syncfill!(X.x1, 1)
BenchmarkTools.Trial:2911 samples with 1 evaluation.
Range (min … max):52.190 μs …2.701 ms ┊ GC (min … max):0.00%…0.00%
Time (median):2.440 ms ┊ GC (median):0.00%
Time (mean ± σ):1.715 ms ±1.091 ms ┊ GC (mean ± σ):0.00%±0.00%
█ ▁▃ ▁ ▇█▇▅▃ ▁
█▁▁▁▁▁██▇█▆█▅▇█▆▅▄▄▅▇▃▃▃▅▆▃▁▁▃▁▃▃▅▄▁▇▁▃▁▁▁▁▁▁▁▃▃▇▄▅▅▆█████ █
52.2 μs Histogram:log(frequency) by time 2.62 ms <
Memory estimate:592 bytes, allocs estimate:19.
julia>@benchmark CUDA.@syncfill!(parent(X.x1), 1)
BenchmarkTools.Trial:4535 samples with 1 evaluation.
Range (min … max):20.560 μs …2.682 ms ┊ GC (min … max):0.00%…0.00%
Time (median):25.200 μs ┊ GC (median):0.00%
Time (mean ± σ):1.101 ms ±1.185 ms ┊ GC (mean ± σ):0.00%±0.00%
█ ▁▂ ▅▅▆▄▂ ▁
█▁▁▁▄▁██▇█▆▆▇▇▇▇▅▁▅▃▇▁▃▄▄▅▁▃▄▅▃▁▁▁▁▄▇▁▃▃▁▁▁▃▁▃▁▃▇▆▅▄▄█████ █
20.6 μs Histogram:log(frequency) by time 2.59 ms <
Memory estimate:128 bytes, allocs estimate:7.
The text was updated successfully, but these errors were encountered:
Our
fill!
method follows ourcopyto!
pattern, which usesCartesianIndex
ing, which is suboptimal especially in the context offill!
, so, we should just forward all of ourfill!
methods tofill!(parent(data), val)
. Here's a local benchmark on an A100 at our target resolution:The text was updated successfully, but these errors were encountered: