From d5778fe5d147f04071755b144405eec2a5fe2c06 Mon Sep 17 00:00:00 2001
From: Akshay Sridhar <asridhar@caltech.edu>
Date: Wed, 9 Nov 2022 14:32:11 -0800
Subject: [PATCH] Add product rule test in : modified:  
 ../../test/Operators/hybrid/2d.jl Includes stretched mesh test

---
 test/Operators/hybrid/2d.jl | 83 ++++++++++++++++++++++++++++++++++++-
 1 file changed, 82 insertions(+), 1 deletion(-)

diff --git a/test/Operators/hybrid/2d.jl b/test/Operators/hybrid/2d.jl
index 93f1622a63..8ba1647d86 100644
--- a/test/Operators/hybrid/2d.jl
+++ b/test/Operators/hybrid/2d.jl
@@ -26,6 +26,7 @@ function hvspace_2D(;
     helem = 10,
     velem = 64,
     npoly = 7,
+    stretch = Meshes.Uniform(),
 )
     FT = Float64
     vertdomain = Domains.IntervalDomain(
@@ -33,7 +34,7 @@ function hvspace_2D(;
         Geometry.ZPoint{FT}(zlim[2]);
         boundary_tags = (:bottom, :top),
     )
-    vertmesh = Meshes.IntervalMesh(vertdomain, nelems = velem)
+    vertmesh = Meshes.IntervalMesh(vertdomain, stretch, nelems = velem)
     vert_center_space = Spaces.CenterFiniteDifferenceSpace(vertmesh)
 
     horzdomain = Domains.IntervalDomain(
@@ -150,6 +151,86 @@ end
     @test conv_adv_c2c[3] ≈ 2 atol = 0.1
 end
 
+@testset "1D SE, 1D FD Extruded Domain Discrete Product Rule Operations" begin
+
+    gradc2f = Operators.GradientC2F(
+        top = Operators.SetValue(0.0),
+        bottom = Operators.SetValue(0.0),
+    )
+    gradf2c = Operators.GradientF2C()
+
+    n_elems_seq = 2 .^ (5, 6, 7, 8)
+    err, Δh = zeros(length(n_elems_seq)), zeros(length(n_elems_seq))
+
+    for (k, n) in enumerate(n_elems_seq)
+        # Discrete Product Rule Test
+        # ∂(ab)/∂s = a̅∂b/∂s + b̅∂a/∂s
+        # a, b are interface variables, and  ̅ represents interpolation
+        # s represents the vertical coordinate, in our case `z`
+        # For this test, we use a(z) = z and b = sin(z),
+        hv_center_space, hv_face_space = hvspace_2D(helem = n, velem = n)
+        ᶠz = Fields.coordinate_field(hv_face_space).z
+        ᶜz = Fields.coordinate_field(hv_center_space).z
+        Δh[k] = 1.0 / n
+
+        # advective velocity
+        # scalar-valued field to be advected
+        ∂ab_numerical = @. Geometry.WVector(gradf2c(ᶠz * sin(ᶠz)))
+        ∂ab_analytical = @. Geometry.WVector(ᶜz * cos(ᶜz) + sin(ᶜz))
+
+        err[k] = norm(∂ab_numerical .- ∂ab_analytical)
+    end
+    # Solution convergence rate
+    grad_pr = convergence_rate(err, Δh)
+    @show grad_pr
+    @test err[3] ≤ err[2] ≤ err[1] ≤ 0.1
+    @test grad_pr[1] ≈ 2 atol = 0.1
+    @test grad_pr[2] ≈ 2 atol = 0.1
+    @test grad_pr[3] ≈ 2 atol = 0.1
+end
+
+@testset "1D SE, 1D FD Extruded Domain Discrete Product Rule Operations: Stretched" begin
+
+    gradc2f = Operators.GradientC2F(
+        top = Operators.SetValue(0.0),
+        bottom = Operators.SetValue(0.0),
+    )
+    gradf2c = Operators.GradientF2C()
+
+    n_elems_seq = 2 .^ (5, 6, 7, 8)
+    err, Δh = zeros(length(n_elems_seq)), zeros(length(n_elems_seq))
+
+    for (k, n) in enumerate(n_elems_seq)
+        # Discrete Product Rule Test
+        # ∂(ab)/∂s = a̅∂b/∂s + b̅∂a/∂s
+        # a, b are interface variables, and  ̅ represents interpolation
+        # s represents the vertical coordinate, in our case `z`
+        # For this test, we use a(z) = z and b = sin(z),
+        hv_center_space, hv_face_space = hvspace_2D(
+            helem = n,
+            velem = n,
+            stretch = Meshes.ExponentialStretching(2π),
+        )
+        ᶠz = Fields.coordinate_field(hv_face_space).z
+        ᶜz = Fields.coordinate_field(hv_center_space).z
+        Δh[k] = 1.0 / n
+
+        # advective velocity
+        # scalar-valued field to be advected
+        ∂ab_numerical = @. Geometry.WVector(gradf2c(ᶠz * sin(ᶠz)))
+        ∂ab_analytical = @. Geometry.WVector(ᶜz * cos(ᶜz) + sin(ᶜz))
+
+        err[k] = norm(∂ab_numerical .- ∂ab_analytical)
+    end
+    # Solution convergence rate
+    grad_pr = convergence_rate(err, Δh)
+    @show grad_pr
+    @test err[3] ≤ err[2] ≤ err[1] ≤ 0.2
+    @test grad_pr[1] ≈ 2 atol = 0.1
+    @test grad_pr[2] ≈ 2 atol = 0.1
+    @test grad_pr[3] ≈ 2 atol = 0.1
+end
+
 @testset "1D SE, 1D FD Extruded Domain horizontal divergence operator" begin
 
     # Divergence Operator