Macro benchmark tests for CT instance creation SDK-3721 #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…creation SDK-3712
…entiate macro benchmarking for different methods of CT instance creation. SDK-3721
…d of reusing sample app. SDK-3721
# Conflicts: # sample/build.gradle # sample/src/main/AndroidManifest.xml
piyush-kukadiya
changed the title
CTLalit
reviewed
Jul 22, 2024
| @@ -144,6 +145,7 @@ dependencies { | |||
| // When using the BoM, you don't specify versions in Firebase library dependencies | |||
| implementation("com.google.firebase:firebase-crashlytics") | |||
| implementation("com.google.firebase:firebase-analytics") | |||
| implementation libs.profileinstaller | |||
CTLalit
reviewed
Jul 22, 2024
Comment on lines
+34
to
+62
| -dontwarn android.telephony.HwTelephonyManager | ||
| -dontwarn com.huawei.android.os.BuildEx$VERSION | ||
| -dontwarn com.huawei.android.telephony.ServiceStateEx | ||
| -dontwarn com.huawei.hianalytics.process.HiAnalyticsConfig$Builder | ||
| -dontwarn com.huawei.hianalytics.process.HiAnalyticsConfig | ||
| -dontwarn com.huawei.hianalytics.process.HiAnalyticsInstance$Builder | ||
| -dontwarn com.huawei.hianalytics.process.HiAnalyticsInstance | ||
| -dontwarn com.huawei.hianalytics.process.HiAnalyticsManager | ||
| -dontwarn com.huawei.hianalytics.util.HiAnalyticTools | ||
| -dontwarn com.huawei.libcore.io.ExternalStorageFile | ||
| -dontwarn com.huawei.libcore.io.ExternalStorageFileInputStream | ||
| -dontwarn com.huawei.libcore.io.ExternalStorageFileOutputStream | ||
| -dontwarn com.huawei.libcore.io.ExternalStorageRandomAccessFile | ||
| -dontwarn com.xiaomi.channel.commonutils.android.Region | ||
| -dontwarn com.xiaomi.mipush.sdk.MiPushClient | ||
| -dontwarn com.xiaomi.mipush.sdk.MiPushMessage | ||
| -dontwarn com.xiaomi.mipush.sdk.PushMessageReceiver | ||
| -dontwarn kotlin.jvm.internal.SourceDebugExtension | ||
| -dontwarn okhttp3.Call | ||
| -dontwarn okhttp3.Callback | ||
| -dontwarn okhttp3.OkHttpClient$Builder | ||
| -dontwarn okhttp3.OkHttpClient | ||
| -dontwarn okhttp3.Request$Builder | ||
| -dontwarn okhttp3.Request | ||
| -dontwarn okhttp3.Response | ||
| -dontwarn org.bouncycastle.crypto.BlockCipher | ||
| -dontwarn org.bouncycastle.crypto.engines.AESEngine | ||
| -dontwarn org.bouncycastle.crypto.prng.SP800SecureRandom | ||
| -dontwarn org.bouncycastle.crypto.prng.SP800SecureRandomBuilder |
There was a problem hiding this comment.
are these part of benchmarking?
CTLalit
reviewed
Jul 22, 2024
Comment on lines
+27
to
+34
| setContent { | ||
| ClevertapandroidsdkTheme { | ||
| // A surface container using the 'background' color from the theme | ||
| Surface(modifier = Modifier.fillMaxSize(), color = MaterialTheme.colorScheme.background) { | ||
| Greeting("Android") | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
can we add correct title and Logo as bare minimum?
CTLalit
reviewed
Jul 22, 2024
| android:theme="@style/Theme.Clevertapandroidsdk"> | ||
| <profileable | ||
| android:shell="true" | ||
| tools:targetApi="29" /> |
There was a problem hiding this comment.
does this have to match with android api which we use?
CTLalit
reviewed
Jul 22, 2024
Comment on lines
+34
to
+42
| <meta-data | ||
| android:name="CLEVERTAP_ACCOUNT_ID" | ||
| android:value="67Z-RRK-696Z" /> | ||
| <meta-data | ||
| android:name="CLEVERTAP_TOKEN" | ||
| android:value="322-1a6" /> | ||
| <meta-data | ||
| android:name="CLEVERTAP_REGION" | ||
| android:value="eu1" /> |
There was a problem hiding this comment.
can we remove these secrets?
CTLalit
reviewed
Jul 22, 2024
Comment on lines
+36
to
+61
| CleverTapAPI.setDebugLevel(VERBOSE) | ||
|
|
||
| /** | ||
| * "bm(benchmark method)" is being passed from macro benchmark tests to tell the Activity which method to benchmark | ||
| */ | ||
| when(intent?.extras?.getString("bm") ?: ""){ | ||
| "initCT" -> trace("init CT") { | ||
| // val measureNanoTime = measureNanoTime { | ||
| // cleverTapDefaultInstance = CleverTapAPI.getDefaultInstance(this) | ||
| val config = CleverTapInstanceConfig.createInstance(this, "TEST-R78-ZZK-955Z", "TEST-311-ba2") | ||
| val cleverTapDefaultInstance = CleverTapAPI.instanceWithConfig(this, config) | ||
| // } | ||
| // Logger.v("nano time ct init = $measureNanoTime") | ||
| } | ||
|
|
||
| "initCTD" -> trace("init CTD") { | ||
| // val measureNanoTime = measureNanoTime { | ||
| val cleverTapDefaultInstance = CleverTapAPI.getDefaultInstance(this) | ||
| // } | ||
| // Logger.v("nano time ct init = $measureNanoTime") | ||
| } | ||
| else -> Log.d("MainActivity","no method specified by benchmark module") | ||
| } | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
extract in method. Format correctly.
CTLalit
reviewed
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes following,