Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why not use Async[F].fromCompletableFuture? #485

Open
buntec opened this issue Jan 9, 2023 · 1 comment
Open

Why not use Async[F].fromCompletableFuture? #485

buntec opened this issue Jan 9, 2023 · 1 comment

Comments

@buntec
Copy link

buntec commented Jan 9, 2023

Hi,

Browsing the Cats Effect module, I noticed the custom converter from CompletableFuture[T] to F[T]. Is there a reason not to use the built-in https://github.com/typelevel/cats-effect/blob/series/3.x/kernel/jvm/src/main/scala/cats/effect/kernel/AsyncPlatform.scala#L32? At first glance it seems to have better cancellation semantics.

Just curious!

Thanks,
Christoph
@Jasper-M
Copy link

This issue has become a bit more serious since Cats Effect 3.5.0 came out and made async_ uncancelable. That means that all operations here are now uncancelable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Jasper-M @buntec