Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement search article feature #12

Open
Ckbhatia opened this issue Oct 4, 2020 · 26 comments
Open

Implement search article feature #12

Ckbhatia opened this issue Oct 4, 2020 · 26 comments
Labels
hacktoberfest up-for-grabs Developer can start working on issues that are labeled up for grabs

Comments

@Ckbhatia
Copy link
Owner

Ckbhatia commented Oct 4, 2020

Implement search article feature

Search element is already there in Header.js component. You need to develop the only functionality.

Use these env variables for development.

# CONTENTFUL_SPACE_ID=0dxfiyfxoovv
# CONTENTFUL_ACCESS_TOKEN=aQ8VH0ajavUGJur3I6LGRTZvjYf25s9ILko6bgLU9z8

Please star the project if you are interested to work on this issue and also don't hesitate to ask for help if you need.

@Ckbhatia Ckbhatia added up-for-grabs Developer can start working on issues that are labeled up for grabs hacktoberfest labels Oct 4, 2020
@trinhminhhieu
Copy link

I will take this

@Ckbhatia
Copy link
Owner Author

Ckbhatia commented Oct 4, 2020

Okay, I am assigning you this.

@Ckbhatia Ckbhatia removed the up-for-grabs Developer can start working on issues that are labeled up for grabs label Oct 4, 2020
@Ckbhatia
Copy link
Owner Author

Ckbhatia commented Oct 4, 2020

Please take a checkout/clone from the feature branch.

@Ckbhatia
Copy link
Owner Author

Ckbhatia commented Oct 6, 2020

Hi @trinhminhhieu, Any update on progress?

@trinhminhhieu
Copy link

hello

@trinhminhhieu
Copy link

I'm solving the last problem, I'm rushing to push it to github tomorrow

@Ckbhatia
Copy link
Owner Author

Ckbhatia commented Oct 6, 2020 via email

@trinhminhhieu
Copy link

trinhminhhieu commented Oct 7, 2020

Hello i don't see any pull request after running git push origin master

@Ckbhatia
Copy link
Owner Author

Ckbhatia commented Oct 7, 2020

Can you elaborate it?

@trinhminhhieu
Copy link

I took Fork and then started your project, after it finished I ran git add. , git commit -m "first", git remote add origin https://github.com/trinhminhhieu/Ck-gatsby-blog.git and finally run git push origin master. But I go back to github and click "Pull requests" but there's no "add pull requests" button.

@trinhminhhieu
Copy link

githug

@Ckbhatia
Copy link
Owner Author

Ckbhatia commented Oct 7, 2020

Wait, Let me guide you!

@Ckbhatia
Copy link
Owner Author

Ckbhatia commented Oct 7, 2020

You need to take a pull from upstream ( original ) master and rebase with your local master or feature ( Where you changes are in ) branch then push changes to your origin master and create a PR on this repo.

You need to follow this:

Set upstream remote:
git remote add upstream https://github.com/Ckbhatia/Ck-gatsby-blog

Pull and rebase the latest changes:
git pull --rebase upstream feature

Push changes to your fork:
git push origin feature

Note: push master instead of feature if you had merged/rebased the changes in the master where your changes are live.

Navigate to this original repo and create a PR against feature branch Instead of the master.

I hope, it is clear now.

@trinhminhhieu
Copy link

it doesn't work

@Ckbhatia
Copy link
Owner Author

Ckbhatia commented Oct 7, 2020 via email

@trinhminhhieu
Copy link

When I run the git push origin feature I get an error
error: src refspec feature does not match any.
error: failed to push some refs to 'origin'

@Ckbhatia
Copy link
Owner Author

Ckbhatia commented Oct 7, 2020

@trinhminhhieu Have you followed the instruction that I have given above?

@trinhminhhieu
Copy link

yes

@trinhminhhieu
Copy link

Should I delete the fork on github and fork again?

@Ckbhatia
Copy link
Owner Author

Ckbhatia commented Oct 7, 2020

No, You don't need to delete

@Ckbhatia
Copy link
Owner Author

Ckbhatia commented Oct 7, 2020

Do you have telegram app?

@trinhminhhieu
Copy link

@higooo

@trinhminhhieu
Copy link

trinhminhhieu commented Oct 7, 2020

please show me how to fix it so I will soon push it to Github

@Ckbhatia
Copy link
Owner Author

Ckbhatia commented Oct 7, 2020

@higooo

Sun life, right?

@Ckbhatia Ckbhatia added the up-for-grabs Developer can start working on issues that are labeled up for grabs label Oct 7, 2020
@alceil
Copy link

alceil commented Oct 1, 2021

Is anyone working on this issue?

@Ckbhatia
Copy link
Owner Author

Ckbhatia commented Oct 4, 2021

Issue already resolved.

@Ckbhatia Ckbhatia added up-for-grabs Developer can start working on issues that are labeled up for grabs hacktoberfest and removed hacktoberfest up-for-grabs Developer can start working on issues that are labeled up for grabs labels Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest up-for-grabs Developer can start working on issues that are labeled up for grabs
Projects
None yet
Development

No branches or pull requests

3 participants