-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement search article feature #12
Comments
I will take this |
Okay, I am assigning you this. |
Please take a checkout/clone from the feature branch. |
Hi @trinhminhhieu, Any update on progress? |
hello |
I'm solving the last problem, I'm rushing to push it to github tomorrow |
Okay, Good!
…On Tue, 6 Oct 2020 at 22:01, trinh minh hieu ***@***.***> wrote:
I'm solving the last problem, I'm rushing to push it to github tomorrow
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#12 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI2SGUN5F6BLYB2MRGKJXWDSJNA6JANCNFSM4SDOH5RQ>
.
|
Hello i don't see any pull request after running git push origin master |
Can you elaborate it? |
I took Fork and then started your project, after it finished I ran git add. , git commit -m "first", git remote add origin https://github.com/trinhminhhieu/Ck-gatsby-blog.git and finally run git push origin master. But I go back to github and click "Pull requests" but there's no "add pull requests" button. |
Wait, Let me guide you! |
You need to take a pull from upstream ( original ) master and rebase with your local master or feature ( Where you changes are in ) branch then push changes to your origin master and create a PR on this repo. You need to follow this: Set upstream remote: Pull and rebase the latest changes: Push changes to your fork: Note: push master instead of feature if you had merged/rebased the changes in the master where your changes are live. Navigate to this original repo and create a PR against feature branch Instead of the master. I hope, it is clear now. |
it doesn't work |
What's error there?
…On Wed, 7 Oct, 2020, 12:47 pm trinh minh hieu, ***@***.***> wrote:
it doesn't work
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#12 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI2SGUJNMR725RJE4T7BEETSJQIX3ANCNFSM4SDOH5RQ>
.
|
When I run the git push origin feature I get an error |
@trinhminhhieu Have you followed the instruction that I have given above? |
yes |
Should I delete the fork on github and fork again? |
No, You don't need to delete |
Do you have telegram app? |
please show me how to fix it so I will soon push it to Github |
Sun life, right? |
Is anyone working on this issue? |
Issue already resolved. |
Implement search article feature
Search element is already there in Header.js component. You need to develop the only functionality.
Use these env variables for development.
Please star the project if you are interested to work on this issue and also don't hesitate to ask for help if you need.
The text was updated successfully, but these errors were encountered: