Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce time required for make start #177

Open
corollari opened this issue Jun 24, 2019 · 2 comments
Open

Reduce time required for make start #177

corollari opened this issue Jun 24, 2019 · 2 comments

Comments

@corollari
Copy link

Describe the Solution

Remove neo-scan from the hot path of make start. This would mean that make start would only set up the basic nodes and start up neo-scan in the background. This change would result in the following difference in output:

Currently:

Starting Docker containers...
Waiting for network.......

After the change:

Starting Docker containers...
Waiting for network.......
Network running! 🎉
neo-scan has been started up but is not currently available, once it has finished booting up we will notify you

(later) "neo-scan is up 🎉"

Why?

According to #4, neo-scan's startup time is significantly slowing down neo-local's start up. Therefore, by removing neo-scan from the hot path of neo-local, we could decrease its booting up time significantly without impacting the workflow, as any system which requires neo-scan could just wait for it to be available (we could also add a flag to put neo-scan back in the hot path to facilitate operation for these systems).

If that sounds like something that you would like added I can implement it myself and submit a PR.

@nunojusto
Copy link
Collaborator

I think that's a nice optimization. Please make a PR.
Thanks

@corollari
Copy link
Author

Taking some time to submit the PR because I can't get neo-local to work and therefore can't test my local changes. Waiting for that to get resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants