From 7195e0f58ea23884ca6e61acf10f36c624ef4128 Mon Sep 17 00:00:00 2001
From: Micah Snyder <micasnyd@cisco.com>
Date: Mon, 28 Aug 2023 00:09:14 -0700
Subject: [PATCH] Visual Studio: Build UnRAR DLL with Debug runtime library

For reasons unknown, after the UnRAR update there are linker errors for
the Release build for 0.103, claiming:

secpassword.obj : error LNK2001: unresolved external symbol _CrtDbgReport
dll.obj : error LNK2001: unresolved external symbol _CrtDbgReport
extinfo.obj : error LNK2001: unresolved external symbol _CrtDbgReport
extract.obj : error LNK2001: unresolved external symbol _CrtDbgReport
headers.obj : error LNK2001: unresolved external symbol _CrtDbgReport
archive.obj : error LNK2001: unresolved external symbol _CrtDbgReport
arcread.obj : error LNK2001: unresolved external symbol _CrtDbgReport
cmddata.obj : error LNK2001: unresolved external symbol _CrtDbgReport
crypt.obj : error LNK2001: unresolved external symbol _CrtDbgReport
...\win32\x64\Release\libclamunrar.dll : fatal error LNK1120: 1 unresolved externals

I haven't been able to determine from reading the diff why it wants
this debug-symbol, but changing the VS project file to link with the
Debug-version of the C runtime DLL appears to resolve the build
issue. Not ideal but I think it is okay.
---
 win32/libclamunrar.vcxproj | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/win32/libclamunrar.vcxproj b/win32/libclamunrar.vcxproj
index 47dce90a24..89860990fa 100644
--- a/win32/libclamunrar.vcxproj
+++ b/win32/libclamunrar.vcxproj
@@ -161,7 +161,7 @@
       <AdditionalIncludeDirectories>$(SolutionDir);$(SolutionDir)compat;$(SolutionDir)..;$(CLAM_DEPENDENCIES)\$(PlatformName)\include</AdditionalIncludeDirectories>
       <MinimalRebuild>false</MinimalRebuild>
       <ExceptionHandling>Sync</ExceptionHandling>
-      <RuntimeLibrary>MultiThreaded</RuntimeLibrary>
+      <RuntimeLibrary>MultiThreadedDebug</RuntimeLibrary>
       <StructMemberAlignment>4Bytes</StructMemberAlignment>
       <BufferSecurityCheck>true</BufferSecurityCheck>
       <FunctionLevelLinking>true</FunctionLevelLinking>
@@ -203,7 +203,7 @@
       <StringPooling>false</StringPooling>
       <MinimalRebuild>false</MinimalRebuild>
       <ExceptionHandling>Sync</ExceptionHandling>
-      <RuntimeLibrary>MultiThreaded</RuntimeLibrary>
+      <RuntimeLibrary>MultiThreadedDebug</RuntimeLibrary>
       <StructMemberAlignment>4Bytes</StructMemberAlignment>
       <BufferSecurityCheck>true</BufferSecurityCheck>
       <FunctionLevelLinking>true</FunctionLevelLinking>