Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The test code may have a little problem when using assertDictEqual #6

Open
F01ivor4 opened this issue Oct 4, 2022 · 1 comment
Open
Assignees
Labels
bug Something isn't working

Comments

@F01ivor4
Copy link

F01ivor4 commented Oct 4, 2022

In IDA_scripts' test code, like test_large_acfg_disasm.py in IDA_acfg_disasm, the code uses assertDictEqual to test if the data feature that readers reproduce is the same as gt's.

However, assertDictEqual will think {'a': [[2, 3], [3, 2]]} != {'a': [[3, 2], [2, 3]]}. But when we reproduce the data feature, like ACFG's edge, we may get different orders of edges, which is also correct.

This is not a big problem, I just hope that the person replicating the code will be aware of this when the test fails.

@jimmy-sonny
Copy link
Contributor

Thanks @LJianCode for reporting this issue. This needs to be fixed.

@jimmy-sonny jimmy-sonny added the bug Something isn't working label Oct 7, 2022
@jimmy-sonny jimmy-sonny self-assigned this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants