Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate between 0 path and max path cannot be calculated #534

Open
louilinn opened this issue Nov 8, 2022 · 4 comments
Open

Separate between 0 path and max path cannot be calculated #534

louilinn opened this issue Nov 8, 2022 · 4 comments
Assignees
Labels
a priority ★★★ confusion 😕 Something is confusing the users

Comments

@louilinn
Copy link
Collaborator

louilinn commented Nov 8, 2022

Currently when there is no path it says the path cannot be calculated. We need to distinguish between 0 value paths and errors in calculating paths.

In send view.

Related PR for this problem: #463
Before this the max amount was loading forever or inaccurately saying 0 maybe

@louilinn
Copy link
Collaborator Author

louilinn commented Nov 8, 2022

We should also change the message to something like: it takes too long to calculate the max path.

Lucia should have input on this too when she is back

@JacqueGM JacqueGM changed the title Seperate between 0 path and max path cannot be calculated Separate between 0 path and max path cannot be calculated Nov 8, 2022
@louilinn louilinn self-assigned this Nov 21, 2022
@louilinn
Copy link
Collaborator Author

Notes:

Message suggestions
"0" should we explain why? link to FAQ if path is 0
"The path takes to long to calculate" because of cmplexity
"The transfer amount requires too many steps in one transaction"

Check the api code, where is the 52 step limitation, what is returned in this case?

@louilinn
Copy link
Collaborator Author

Screenshot from 2022-11-27 11-14-23

Current error message for too high amounts being attempted to be sent

@louilinn
Copy link
Collaborator Author

louilinn commented Jan 9, 2023

The new pathfinder will respond in more ways and those should be treated here too.
@llunaCreixent will elaborate on these scenarios

@triaslucia this is the issue for the Send Confirm view that is mentioned in our meeting notes as your task to specify texts for.

@llunaCreixent llunaCreixent self-assigned this Jan 9, 2023
@louilinn louilinn added confusion 😕 Something is confusing the users a priority ★★★ labels Oct 10, 2023
@llunaCreixent llunaCreixent removed their assignment Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a priority ★★★ confusion 😕 Something is confusing the users
Projects
None yet
Development

No branches or pull requests

2 participants