Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With poetry package manager, cache is not used if virtualenvs.in-project is true #115

Open
nicholasbailey opened this issue Aug 8, 2023 · 2 comments

Comments

@nicholasbailey
Copy link

Orb version: 2.1.1

What happened:

In a project with the specified configuration parameter, the orb will make no use of the cache and will reinstall dependencies every single time. This is because the orb hardcodes the poetry virtualenv location, rather than determining it based on that configuration setting.

Expected behavior:

Cache should be used regardless of venv location configuration within poetry

Additional Information:

This should be relatively easy to fix, so I should have a PR addressing it shortly.

@pabloxio
Copy link

pabloxio commented Sep 1, 2023

I was having the same issue and the following worked for me:

    - python/install-packages:
        pkg-manager: poetry
        # Override the venv path
        venv-path: '["/home/circleci/project/.venv"]'
        # I had to clear the cache-version
        # otherwise, the "Saving cache" step would skip the new "venv-path" value
        cache-version: v2

@marboledacci
Copy link
Contributor

Is there something else to do here, or the provided solution does work and we can close it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants