Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security patches :D #7

Open
wants to merge 14 commits into
base: eleven
Choose a base branch
from
Open

Conversation

Meghthedev
Copy link

No description provided.

@techyminati
Copy link
Member

Looks good to me, does it build fine @Meghthedev ?

@Meghthedev
Copy link
Author

Meghthedev commented Oct 6, 2023

Looks good to me, does it build fine @Meghthedev ?

Well, I would need to build and check, also ig the recent sp is left to be merged, I'll do that within a few days and push, last time I checked it worked fine, but I would test it first

* external/freetype
* tools/apksig

Change-Id: Icec158450e745aa6b9be3b6019d773266145d85f
@techyminati
Copy link
Member

@Meghthedev Have you tested these?

@Meghthedev
Copy link
Author

@Meghthedev Have you tested these?

syncing the source right now, will send a screenshot once the build boots

* packages/apps/QuickAccessWallet
* system/ca-certificates
* external/aac
@alibei
Copy link
Member

alibei commented Oct 9, 2023

Looks good! Look forward to the screenshots

@Meghthedev
Copy link
Author

@techyminati @alibei i built the rom, but i get this error
https://paste.crdroid.net/8fFEkI
i am building on arch, and in general i have problems with a11 roms building on my pc, ( corvus a11 also had this issue)i think it has to do with some package being too new, as the same source builds just fine on my server ( which i dont have rn) which runs ubuntu 22.04, it also works on debian 11 or lower, so if you have some fix for this issue, give it so, else everything is fine to merge ( if there might be an erorr after my current error, then i dont know) below is the list of pull requests to merge, so you dont miss any
#7
CipherOS/android_frameworks_opt_telephony#2
CipherOS/android_vendor_cipher#7
CipherOS/android_packages_apps_Settings#4
CipherOS/android_build_soong#2
CipherOS/android_packages_apps_Trebuchet#1
CipherOS/android_build#3
CipherOS/android_frameworks_opt_net_wifi#1
CipherOS/android_frameworks_base#7
CipherOS/android_frameworks_native#2
CipherOS/android_packages_services_Telephony#1
CipherOS/android_frameworks_av#2
CipherOS/android_packages_services_Telecomm#1
CipherOS/android_packages_apps_Dialer#1

@Meghthedev
Copy link
Author

So, it seems like my arch install is broken, i managed to get it built, and will test right now,
i have reverted the versioning that i did back to what it was, - astra, you can change it to whatever the team decides ( your probably know this but change it in vendor and Settings)

@techyminati
Copy link
Member

Let us know if it boots fine

@Meghthedev
Copy link
Author

@techyminati it does boot great! attaching screenshots below
20231012_093730909
Screenshot_20231012-093814_Cipher_Launcher
20231012_093743152
20231012_093752943
20231012_093712697

@techyminati
Copy link
Member

@Meghthedev Looks good to me, waiting for approval from @alibei

@sarthakroy2002
Copy link

@Meghthedev Looks good to me..... Approved...

*external/libcups
*external/webp
*packages/modules/DnsResolver
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants