Fix typo in Remove-Packages #2881
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@leonardo-dgs, it has wildcard characters. It will always spot |
|
I know, indeed is a refactoring. |
|
It's not a big deal though. It looks nice and, if it still works, it can be merged. Have you made a test image with your change and verified that it works correctly, @leonardo-dgs? |
|
Powershell string comparison operators are usually not case sensitive, maybe that was the thought behind starting with *i. |
|
I've tested, and it works |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Fix typo in Remove-Packages function:
"*indows-Client-LanguagePack*"instead of"*Windows-Client-LanguagePack*"