Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Use CADT projectId for metadata when creating a token #57

Open
ccornick opened this issue Jul 6, 2023 · 1 comment
Open

FEAT: Use CADT projectId for metadata when creating a token #57

ccornick opened this issue Jul 6, 2023 · 1 comment
Assignees

Comments

@ccornick
Copy link
Collaborator

ccornick commented Jul 6, 2023

Currently, the metadata that gets written when a new CAT is created shows warehouseProjectId. Instead, this should list projectId.

This should be a simple change in the token driver to simply write the associated projectId where warehouseProjectId used to be in metadata writes.

"meta_0x890e67c49ddb55aac4c12a6cce1fc08eabcb7d8faf0d93e34ac13449c3c7a96d": "{"org_uid":"76b481967bac9350513c476923d1a129a4c3429c424c55ff546890a0cdb13b43","warehouse_project_id":"b6cc6eb5-d14b-49e6-9818-7d885d38fe5b","vintage_year":2018,"sequence_num":0,"index":"0xdb75bd3d448a90297579a1aa14762c4c6f346f7d58b74468be09bf004111a2a6","public_key":"0xa9d5c7420d5a982461c410852f3b4079cef7cf970c2d46bf6508bfc7ad05094d54c29fd414eaea64efd05aaf9f29d830","asset_id":"0x890e67c49ddb55aac4c12a6cce1fc08eabcb7d8faf0d93e34ac13449c3c7a96d","tokenization":{"mod_hash":"0x3de02f5b653274fd267ea1b5edb392ef69b07bc0daa4faedfa46fbc90dd237d1","public_key":"0xb0f0c9c5f0558850352ef6af255443fd983b9fce0f06b8c8b2dc3452f3aa076798239d185eb48b505e43e5b78daa680e"},"detokenization":{"mod_hash":"0x753e258876029bbb4b7122e1daf311e1f50b8f8820ba08d3d742924634662aa5","public_key":"0xa40d1a5549ea6481fe22dcb3fcecd1b04972a4eb613a7e61e5729683542494eb15afbb798753ce105ada6053626ce3fb","signature":"0xb21dcd0cefad256b6c07a915e395f8aed8c4ea6751b91dca8141054b34497e928f1f5ce8f9799875c8db196f862d6a2b178bc46a395e9b105524d1d014498228e3182b7a71358f9216bdbcda19d4f4888708b57bb0ed2a4b823e2c5d9aa6dfc4"},"permissionless_retirement":{"mod_hash":"0xe5a960fca43b67ec76d1d4ea863dc4037974d5ea0239eacbff35646daa571bf9","signature":"0x9732d2fee191b1d940986b5fa135ed67a0546c5f69f48fd7280896a4d386b0c2bd0d900da3c0e8259e7f4bb369880fb8174a61c4a0315c824b9d3da9c996b9f0fc9a80d9bc7576eb5db167c7f890a221322c94e4b4820b2a0f86b0cd8bca13b1"}}",

@MichaelTaylor3D
Copy link
Collaborator

If i understand this correctly, we need to change the field name in the tokenization index and in the metadata output. Renaming the field from warehouse_project_id to project_id has major implication and can break a lot.

The easy way is to simply change the value, and leave the field name as it is, but then you have a field name mismatch that could be hard to maintain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants