From 2e6adcba857ec73faca544bee64a408c0bda0dde Mon Sep 17 00:00:00 2001 From: Kyle Altendorf Date: Wed, 25 Sep 2024 15:06:10 -0400 Subject: [PATCH 1/2] remove `.from_parent()` hinting at least for now --- wheel/generate_type_stubs.py | 5 ----- wheel/python/chia_rs/chia_rs.pyi | 6 ------ wheel/stubtest.allowlist | 10 +++++++++- 3 files changed, 9 insertions(+), 12 deletions(-) diff --git a/wheel/generate_type_stubs.py b/wheel/generate_type_stubs.py index f4903ef60..1db73d5a0 100644 --- a/wheel/generate_type_stubs.py +++ b/wheel/generate_type_stubs.py @@ -166,7 +166,6 @@ def parse_rust_source(filename: str, upper_case: bool) -> List[Tuple[str, List[s extra_members = { "Coin": [ "def name(self) -> bytes32: ...", - "@classmethod\n def from_parent(cls, _coin: Self): ...", ], "ClassgroupElement": [ "@staticmethod\n def create(bytes) -> ClassgroupElement: ...", @@ -225,7 +224,6 @@ def parse_rust_source(filename: str, upper_case: bool) -> List[Tuple[str, List[s "def uncurry(self) -> Tuple[ChiaProgram, ChiaProgram]: ...", ], "SpendBundle": [ - "@classmethod\n def from_parent(cls, spend_bundle: Self): ...", "@classmethod\n def aggregate(cls, spend_bundles: List[SpendBundle]) -> Self: ...", "def name(self) -> bytes32: ...", "def removals(self) -> List[Coin]: ...", @@ -241,9 +239,6 @@ def parse_rust_source(filename: str, upper_case: bool) -> List[Tuple[str, List[s "def ip_iters(self, constants: ConsensusConstants) -> uint64: ...", "def sp_total_iters(self, constants: ConsensusConstants) -> uint128: ...", ], - "CoinSpend": [ - "@classmethod\n def from_parent(cls, cs: Self): ...", - ], } classes = [] diff --git a/wheel/python/chia_rs/chia_rs.pyi b/wheel/python/chia_rs/chia_rs.pyi index 7b5943a11..d11412604 100644 --- a/wheel/python/chia_rs/chia_rs.pyi +++ b/wheel/python/chia_rs/chia_rs.pyi @@ -603,8 +603,6 @@ class Coin: puzzle_hash: bytes32 amount: uint64 def name(self) -> bytes32: ... - @classmethod - def from_parent(cls, _coin: Self): ... def __init__( self, parent_coin_info: bytes, @@ -637,8 +635,6 @@ class CoinSpend: coin: Coin puzzle_reveal: Program solution: Program - @classmethod - def from_parent(cls, cs: Self): ... def __init__( self, coin: Coin, @@ -2342,8 +2338,6 @@ class SpendBundle: coin_spends: List[CoinSpend] aggregated_signature: G2Element @classmethod - def from_parent(cls, spend_bundle: Self): ... - @classmethod def aggregate(cls, spend_bundles: List[SpendBundle]) -> Self: ... def name(self) -> bytes32: ... def removals(self) -> List[Coin]: ... diff --git a/wheel/stubtest.allowlist b/wheel/stubtest.allowlist index 248a7acb3..f8c303124 100644 --- a/wheel/stubtest.allowlist +++ b/wheel/stubtest.allowlist @@ -43,7 +43,7 @@ chia_rs.sized_byte_class.Iterable chia_rs.sized_byte_class.BinaryIO.write chia_rs.struct_stream.BinaryIO.write -# TODO: why are we implementing these just so they can report not implemented? +# these raise unimplemented chia_rs.G1Element.from_parent chia_rs.G2Element.from_parent chia_rs.GTElement.from_parent @@ -61,3 +61,11 @@ chia_rs.chia_rs.SpendBundleConditions.from_parent chia_rs.chia_rs.SpendConditions.from_parent chia_rs.spend.Spend.from_parent chia_rs.spend.SpendConditions.from_parent + +# these are impemented but not intended to be called from python +chia_rs.Coin.from_parent +chia_rs.CoinSpend.from_parent +chia_rs.SpendBundle.from_parent +chia_rs.chia_rs.Coin.from_parent +chia_rs.chia_rs.CoinSpend.from_parent +chia_rs.chia_rs.SpendBundle.from_parent From e31b12613b5ea09e909364474f16e50430a77415 Mon Sep 17 00:00:00 2001 From: Kyle Altendorf Date: Wed, 25 Sep 2024 15:06:57 -0400 Subject: [PATCH 2/2] typo --- wheel/stubtest.allowlist | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/wheel/stubtest.allowlist b/wheel/stubtest.allowlist index f8c303124..36d5afaf3 100644 --- a/wheel/stubtest.allowlist +++ b/wheel/stubtest.allowlist @@ -62,7 +62,7 @@ chia_rs.chia_rs.SpendConditions.from_parent chia_rs.spend.Spend.from_parent chia_rs.spend.SpendConditions.from_parent -# these are impemented but not intended to be called from python +# these are implemented but not intended to be called from python chia_rs.Coin.from_parent chia_rs.CoinSpend.from_parent chia_rs.SpendBundle.from_parent