Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] On-demand minting is stopping working since v1.7.1 #15250

Open
wizicer opened this issue May 10, 2023 · 5 comments
Open

[Bug] On-demand minting is stopping working since v1.7.1 #15250

wizicer opened this issue May 10, 2023 · 5 comments
Assignees
Labels
1.8.0 bug Something isn't working GUI Related to the Chia GUI NFT offers Windows Impacts Windows

Comments

@wizicer
Copy link
Contributor

wizicer commented May 10, 2023

What happened?

On-demand minting is stopping working since v1.7.1

  • Last working version: 1.7.0
  • Confirmed Bug version: 1.7.1/1.8.0/1.8.0b4-dev30(local)

Seems Chia Client checks the NFT existence before accepting offer. error with Coin record 0xd74d8c080d9fc28eaa4bb10b04897d922568d775d5cfdfa730af70e12d2e6db1 not found

But on-demand minting would not create the NFT before offer taken.

How the spend bundle look like

image

0xd74d8c080d9fc28eaa4bb10b04897d922568d775d5cfdfa730af70e12d2e6db1 is the coin I pointed in above image.

How are you minting the nft?

We created partial spend bundle of NFT minting which required the offer to be successfully taken through puzzle announcement
The NFT only minted when the offer accepted.

You can try in https://xch.cool/ .
Try to register and make one offer, then you can inspect this offer in https://mixch.dev/

Why it matters

I believe on-demand minting should be a useful feature benefit lots of scenarios, like mint blind box on-demand.

How to reproduce

Version

1.7.1/1.8.0/1.8.0b4-dev30

What platform are you using?

Windows

What ui mode are you using?

GUI

Relevant log output

2023-05-05T20:12:33.355 wallet chia.rpc.rpc_server        : WARNING  Error while handling message: Traceback (most recent call last):
  File "chia\rpc\rpc_server.py", line 340, in safe_handle
  File "chia\rpc\rpc_server.py", line 331, in ws_api
  File "chia\rpc\wallet_rpc_api.py", line 2662, in nft_get_info
  File "chia\rpc\wallet_rpc_api.py", line 277, in get_latest_singleton_coin_spend
ValueError: Coin record 0xd74d8c080d9fc28eaa4bb10b04897d922568d775d5cfdfa730af70e12d2e6db1 not found

2023-05-05T20:12:33.483 wallet chia.rpc.rpc_server        : WARNING  Error while handling message: Traceback (most recent call last):
  File "chia\rpc\rpc_server.py", line 340, in safe_handle
  File "chia\rpc\rpc_server.py", line 331, in ws_api
  File "chia\rpc\wallet_rpc_api.py", line 2662, in nft_get_info
  File "chia\rpc\wallet_rpc_api.py", line 277, in get_latest_singleton_coin_spend
ValueError: Coin record 0xd74d8c080d9fc28eaa4bb10b04897d922568d775d5cfdfa730af70e12d2e6db1 not found
@wizicer wizicer added the bug Something isn't working label May 10, 2023
@MumfMeisterT MumfMeisterT added GUI Related to the Chia GUI Windows Impacts Windows offers NFT 1.8.0 labels May 11, 2023
@MumfMeisterT
Copy link

How do you believe royalties should work in this use case? Does the user enter the royalty? The issue is that the coin doesn't exist, so we can't look this up.

@wizicer
Copy link
Contributor Author

wizicer commented May 14, 2023

It works:

  1. It works in v1.7.0 and before. Only failed since v1.7.1.
  2. The NFT is ephemeral coin in the spend bundle, the royalty can be calculated from there.

@MumfMeisterT MumfMeisterT assigned trepca and mando222 and unassigned trepca May 18, 2023
@MumfMeisterT
Copy link

@wizicer We will have DevRel reach out to you to discuss further.

@wizicer
Copy link
Contributor Author

wizicer commented Jun 2, 2023

@wizicer We will have DevRel reach out to you to discuss further.

I haven't received any message from DevRel until now, could you check with DevRel again?

@punish-yh
Copy link

someone can fix this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.8.0 bug Something isn't working GUI Related to the Chia GUI NFT offers Windows Impacts Windows
Projects
None yet
Development

No branches or pull requests

5 participants