-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add compression support to metrics and RPC servers #4906
Open
hanabi1224
wants to merge
3
commits into
main
Choose a base branch
from
hm/http-server-compression
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+109
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanabi1224
commented
Oct 16, 2024
src/rpc/mod.rs
Outdated
@@ -485,6 +486,13 @@ where | |||
svc_builder, | |||
keystore, | |||
} = per_conn.clone(); | |||
let http_middleware = tower::ServiceBuilder::new() | |||
// This does not compile yet, a fix has been made in https://github.com/paritytech/jsonrpsee/pull/1475 | |||
// .layer(CompressionLayer::new()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can uncomment this line in a subsequent PR once a new version of jsonrpsee
is released.
hanabi1224
requested review from
lemmih and
elmattic
and removed request for
a team
October 16, 2024 15:09
hanabi1224
commented
Oct 16, 2024
@@ -184,7 +184,8 @@ tokio = { version = "1", features = ['full'] } | |||
tokio-stream = { version = "0.1", features = ["fs", "io-util"] } | |||
tokio-util = { version = "0.7", features = ["compat", "io-util"] } | |||
toml = "0.8" | |||
tower = { version = "0.5", features = ["full"] } | |||
tower = { version = "0.4", features = ["util"] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
downgrade tower
to align with jsonrpsee
elmattic
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Part of #4903
Changes introduced in this pull request:
blocked on fix(server): make tower::Service impl generic over HttpBody paritytech/jsonrpsee#1475)Authorization
request header as sensitive so it doesn't show in logsjsonrpsee
Reference issue to close (if applicable)
Closes #4903
Other information and links
Change checklist