fix: failing macos build, wrong arch, missing wallet #4905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LesnyRumcajs
requested review from
elmattic and
sudo-shashank
and removed request for
a team
hanabi1224
reviewed
Oct 16, 2024
| - name: Cargo Build | ||
| run: cargo build --release --bin forest --bin forest-cli --bin forest-tool | ||
| run: cargo build --release --bin forest --bin forest-cli --bin forest-tool --bin forest-wallet |
There was a problem hiding this comment.
Good point. I'll go ahead and simplify it.
hanabi1224
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
macos-latestmoved to arm-based workers)Reference issue to close (if applicable)
Closes
Other information and links
Change checklist