Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(rpc): pairty test for Filecoin.F3GetECPowerTable #4892

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Oct 14, 2024

Summary of changes

Changes introduced in this pull request:

  • API compare tests for Filecoin.F3GetECPowerTable(which does not require F3 to be running)
  • (Parity tests for other F3 methods will come later when F3 is enabled by default)
| RPC Method                      | Forest | Lotus |
|---------------------------------|--------|-------|
| Filecoin.F3GetECPowerTable (11) | Valid  | Valid |

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@hanabi1224 hanabi1224 marked this pull request as ready for review October 14, 2024 15:34
@hanabi1224 hanabi1224 requested a review from a team as a code owner October 14, 2024 15:34
@hanabi1224 hanabi1224 requested review from lemmih and sudo-shashank and removed request for a team October 14, 2024 15:34
@lemmih lemmih added this pull request to the merge queue Oct 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 15, 2024
@hanabi1224 hanabi1224 added this pull request to the merge queue Oct 15, 2024
Merged via the queue into main with commit 88a9de3 Oct 15, 2024
32 of 33 checks passed
@hanabi1224 hanabi1224 deleted the hm/parity-test-F3GetECPowerTable branch October 15, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants