Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: TukTuk 2k network #4872

Merged
merged 1 commit into from
Oct 10, 2024
Merged

feat: TukTuk 2k network #4872

merged 1 commit into from
Oct 10, 2024

Conversation

LesnyRumcajs
Copy link
Member

@LesnyRumcajs LesnyRumcajs commented Oct 10, 2024 •
edited
Loading

Summary of changes

Changes introduced in this pull request:

  • updated 2k network and tackled some missing Rust code changes,
  • apparently the prefix for devnet addresses changed. It might be a regression in lotus-seed, I asked in their channel, so we may revert that particular change in the future.
v1.30-rc1
❯ ./lotus-seed --sector-dir /tmp/genesis-sectors pre-seal --sector-size 2KiB --num-sectors 2

...
2024-10-10T12:16:54.439+0200    INFO    preseal seed/seed.go:228        Writing preseal manifest to /tmp/genesis-sectors/pre-seal-f01000.json

v1.29.2
❯ ./lotus-seed --sector-dir /tmp/genesis-sectors pre-seal --sector-size 2KiB --num-sectors 2

....
2024-10-10T12:19:27.533+0200    INFO    preseal seed/seed.go:228        Writing preseal manifest to /tmp/genesis-sectors/pre-seal-t01000.json

Reference issue to close (if applicable)

Closes #4802

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

LesnyRumcajs
LesnyRumcajs commented Oct 10, 2024
View reviewed changes
src/shim/actors/state_load.rs
actor_state_load_impl!(System, 8, V8, 9, V9, 10, V10, 11, V11, 12, V12, 13, V13, 14, V14);
actor_state_load_impl!(Verifreg, 8, V8, 9, V9, 10, V10, 11, V11, 12, V12, 13, V13, 14, V14);
actor_state_load_impl!(Reward, 8, V8, 9, V9, 10, V10, 11, V11, 12, V12, 13, V13, 14, V14);
actor_state_load_impl!(Account, 8, V8, 9, V9, 10, V10, 11, V11, 12, V12, 13, V13, 14, V14, 15, V15);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should probably write another macro here in the future!

@LesnyRumcajs LesnyRumcajs marked this pull request as ready for review October 10, 2024 11:13
@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner October 10, 2024 11:13
@LesnyRumcajs LesnyRumcajs requested review from hanabi1224 and elmattic and removed request for a team October 10, 2024 11:13
elmattic
elmattic approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@elmattic elmattic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Oct 10, 2024
Merged via the queue into main with commit 4f794e1 Oct 10, 2024
38 checks passed
@LesnyRumcajs LesnyRumcajs deleted the 2k-network-tuktuk branch October 10, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanabi1224 hanabi1224 hanabi1224 approved these changes

@elmattic elmattic elmattic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[NV24] 2k network testing
3 participants
@LesnyRumcajs @hanabi1224 @elmattic