Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dockerfile): bump golang version in lotus.dockerfile #4854

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Oct 7, 2024

Summary of changes

Lotus has upgraded Go to 1.22 in its v1.29.2 release, this PR updates the Dockerfiles accordingly.

https://github.com/filecoin-project/lotus/blob/v1.29.2/go.mod#L3

CI to build new image from this branch: https://github.com/ChainSafe/forest/actions/runs/11224471498/job/31201254574#step:8:30

Changes introduced in this pull request:

  • update lotus.dockerfile(s)
  • update lotus-devnet image tags

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@@ -1,5 +1,5 @@
# Lotus binaries image, to be used in the local devnet with Forest.
FROM golang:1.21-bookworm AS lotus-builder
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 2 lotus.dockerfile(s) are identical, should we delete this one?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should re-use the existing one. That said, @lemmih believes both composes will eventually get merged (or rather, the lotus-miner will get replaced by curio). See comments in #4760

@hanabi1224 hanabi1224 marked this pull request as ready for review October 8, 2024 03:19
@hanabi1224 hanabi1224 requested a review from a team as a code owner October 8, 2024 03:19
@hanabi1224 hanabi1224 requested review from lemmih and sudo-shashank and removed request for a team October 8, 2024 03:19
@ruseinov ruseinov self-requested a review October 8, 2024 08:41
@ruseinov ruseinov added this pull request to the merge queue Oct 8, 2024
Merged via the queue into main with commit 343a4b6 Oct 8, 2024
38 checks passed
@ruseinov ruseinov deleted the hm/bump-go-in-lotus-dockerfile branch October 8, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants