Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use fn get_required_* to avoid uninformative <Option as anyhow::Context>::context calls #4293

Merged
merged 1 commit into from
May 8, 2024
Merged

chore: use fn get_required_* to avoid uninformative <Option as anyhow::Context>::context calls #4293

merged 1 commit into from
May 8, 2024

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented May 8, 2024 •
edited
Loading

Summary of changes

Changes introduced in this pull request:

  • simplify CborStore::get_cbor(params)?.context(params)? with CborStore::get_cbor_required(params)?
  • simplify StateManager::get_actor(params)?.context(params)? with StateManager::get_required_actor(params)?

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@hanabi1224 hanabi1224 marked this pull request as ready for review May 8, 2024 07:42
@hanabi1224 hanabi1224 requested a review from a team as a code owner May 8, 2024 07:42
@hanabi1224 hanabi1224 requested review from ruseinov and aatifsyed and removed request for a team May 8, 2024 07:42
@hanabi1224 hanabi1224 added this pull request to the merge queue May 8, 2024
Merged via the queue into main with commit bb4f5c7 May 8, 2024
44 of 47 checks passed
@hanabi1224 hanabi1224 deleted the hm/less-option-context branch May 8, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemmih lemmih lemmih approved these changes

@LesnyRumcajs LesnyRumcajs LesnyRumcajs approved these changes

@ruseinov ruseinov Awaiting requested review from ruseinov ruseinov is a code owner automatically assigned from ChainSafe/forest

@aatifsyed aatifsyed Awaiting requested review from aatifsyed aatifsyed is a code owner automatically assigned from ChainSafe/forest

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hanabi1224 @lemmih @LesnyRumcajs