Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rpc): Filecoin.StateSectorGetInfo #4117

Closed
wants to merge 1 commit into from
Closed

fix(rpc): Filecoin.StateSectorGetInfo #4117

wants to merge 1 commit into from

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Mar 27, 2024 •
edited
Loading

Summary of changes

Changes introduced in this pull request:

  • Fix RPC method Filecoin.StateSectorGetInfo
| RPC Method                  | Forest | Lotus |
|-----------------------------|--------|-------|
| Filecoin.StateSectorGetInfo | Valid  | Valid |

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@hanabi1224 hanabi1224 force-pushed the hm/rpc-fix-state-sector-get-info branch from 446386e to 854bdb4 Compare March 27, 2024 05:49
@hanabi1224 hanabi1224 marked this pull request as ready for review March 27, 2024 05:50
@hanabi1224 hanabi1224 requested a review from a team as a code owner March 27, 2024 05:50
@hanabi1224 hanabi1224 requested review from ruseinov and elmattic and removed request for a team March 27, 2024 05:50
@hanabi1224
Copy link
Contributor Author

Hmm, this fix works with lotus-1.27.0-dev but not current lotus-1.26.0

@hanabi1224 hanabi1224 marked this pull request as draft March 27, 2024 07:46
@hanabi1224
Copy link
Contributor Author

Superseded by #4286

@hanabi1224 hanabi1224 closed this May 6, 2024
@hanabi1224 hanabi1224 deleted the hm/rpc-fix-state-sector-get-info branch May 6, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruseinov ruseinov Awaiting requested review from ruseinov ruseinov is a code owner automatically assigned from ChainSafe/forest

@elmattic elmattic Awaiting requested review from elmattic elmattic is a code owner automatically assigned from ChainSafe/forest

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hanabi1224