Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Feature: "Contracts" => enable/disable contract integration tests #80

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jonas089
Copy link

@jonas089 jonas089 commented Oct 9, 2024

This PR introduces a change that helps satisfy rust-analyzer when cloning the spectre repo and opening it in an IDE.
I introduce a dummy crate with a readme pointing to the real contracts crate and a feature that makes the dependency on contract integration tests optional.

I believe that this is an improvement to the workspace since we can't push the compiled binaries to GitHub and we want developers to be able to isolate and test / work on the ZK logic without having to bother setting up Smart Contracts / pulling in the external crate.

@nulltea agrees to my proposal which is why I have decided to create this PR. Please comment for suggestions and further improvements :).

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants