Rotation - Adds input encoding in Solidity and compatibility tests #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
willemolding
commented
Oct 11, 2023
•
willemolding
commented
- Adds a new test for ensuring the input encoding matches between Rust and Solidity for the rotation circuit
- Adds presumed missing line to instance encoding so the finalized_block_ssz is included
- Adds Solidity function to perform the encoding from inputs
willemolding
commented
Oct 11, 2023
willemolding
commented
Oct 11, 2023
|
Also just did a reverse on the bytes of the pubkeys because of a difference of endieness between bls library and witness data. Previously had to do it for the step circuit witness as well. |
ec2
reviewed
Oct 11, 2023
nulltea
requested changes
Oct 13, 2023
…inSafe/Spectre into willem/rotate-input-encoder-solidity
ec2
approved these changes
Oct 19, 2023
nulltea
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.