Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ec2/rotation merkle instances #23

Merged
merged 23 commits into from
Oct 10, 2023
Merged

Ec2/rotation merkle instances #23

merged 23 commits into from
Oct 10, 2023

Conversation

ec2
Copy link
Member

@ec2 ec2 commented Oct 5, 2023

The Committee Update circuit now exposes the finalized block root as an instance. Also fixed some bugs in circuit merklization

@nulltea nulltea linked an issue Oct 5, 2023 that may be closed by this pull request
@ec2 ec2 marked this pull request as ready for review October 6, 2023 10:42
@ec2
Copy link
Member Author

ec2 commented Oct 6, 2023

BTW, I've tried K=23 for the AggregationCircuit and K=20 for the app circuit, and contract size (28k) is still too big 😬 ...

@ec2
Copy link
Member Author

ec2 commented Oct 9, 2023

Proving time is 96s + 294s + 182s = 572s for App_K = 18, Agg1_K = 23, Agg2_K = 23. Contract size is 23436B.

Copy link
Member

@nulltea nulltea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; thanks for the fixes.

@ec2 ec2 merged commit 7f0018d into main Oct 10, 2023
1 check failed
@ec2 ec2 deleted the ec2/rotation-merkle-instances branch October 10, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing components in instance commitments
2 participants