Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve raster overlay error reporting and handling #945

Merged
merged 9 commits into from
Sep 25, 2024

Conversation

kring
Copy link
Member

@kring kring commented Sep 6, 2024

Previously, if a raster overlay tile provider ran into an error while loading overlay images (for example, if a WMS server returned an error because it didn't support EPSG:4236), those errors were ignored, and the tileset wouldn't show up at all. This was pretty unhelpful for users, who had no way to learn what was happening except by using the debugger. With this PR:

  1. Errors loading raster overlays are logged.
  2. Raster overlay failures will no longer stop the geometry tile they're attached to from rendering. Instead, once the image load fails, the geometry tile will simply be rendered without any raster overlay.

@kring kring added this to the October 2024 Release milestone Sep 9, 2024
@j9liu j9liu self-requested a review September 9, 2024 17:39
@j9liu
Copy link
Contributor

j9liu commented Sep 12, 2024

@kring This looks good to me! I wanted to verify the behavior where tilesets can still load with erroneous overlays, but if I don't get to it in time it's okay to merge.

@j9liu
Copy link
Contributor

j9liu commented Sep 13, 2024

@kring I tested this in Unreal with a Cesium ion raster overlay draped on CWT, and set it to a non-imagery asset ID (like 1). Unfortunately this did prevent CWT from rendering. But maybe this case is special?

In any case I also tested this with an invalid WMS base URL, and found that it still prevented CWT from rendering... I swear I'm using this branch and that I rebuilt the extern folder. :')

image

Do you see something different? Maybe I'm testing the wrong cases?

@kring
Copy link
Member Author

kring commented Sep 17, 2024

That should be working now @j9liu. I was testing with raster overlays that could successfully create a tile provider, but then all of the tile loads failed. In your (perfectly valid) test, the tile provider creation itself was failing. That's handled now, too.

@j9liu
Copy link
Contributor

j9liu commented Sep 25, 2024

Thanks @kring! I tested with the same cases I wrote above and the tileset's no longer blocked by the invalid overlay. I also see errors related to raster overlay tiles being logged to the console. Merging now!

@j9liu j9liu merged commit 5dd0841 into main Sep 25, 2024
24 checks passed
@j9liu j9liu deleted the overlay-error-reporting branch September 25, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants