Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCF version reading - don't use stringview.compare(). Fixes #142 #143

Merged
merged 1 commit into from
Aug 20, 2023

Conversation

cboulay
Copy link
Collaborator

@cboulay cboulay commented Aug 20, 2023

This modifies how CCFUtilsXml reads the version number from the first element in a CCF file.
I also added a dummy test application to read the CCF. While it seems to be working, and the packets are indeed getting the information they need from the CCF, the send-on-read is not working. That can be investigated in a different effort.

@cboulay
Copy link
Collaborator Author

cboulay commented Aug 20, 2023

Developed and tested in Mac. There were some network issues when sending the CCF packets but that particular connection always has issues.

Then confirmed working well in Windows.

@cboulay cboulay merged commit b1eae8e into master Aug 20, 2023
4 checks passed
@cboulay cboulay deleted the fixup_ccf branch August 20, 2023 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant