Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/remove unused imports #81

Merged
merged 3 commits into from
Sep 1, 2023
Merged

Conversation

Raid5594
Copy link
Contributor

@Raid5594 Raid5594 commented Aug 25, 2023

Small PR to remove warnings on compilation of both node and tests

  • remove unused imports
  • replace deprecated imports
  • remove unused macros

@khssnv
Copy link
Member

khssnv commented Aug 29, 2023

@Raid5594, please squash commits with the same commit message or change commit messages to make them different. Please also fix an error that occurred during the CI check.

@khssnv
Copy link
Member

khssnv commented Aug 29, 2023

Also please remove unused imports from tests if possible.

@Raid5594 Raid5594 force-pushed the feature/remove-unused-imports branch from 5cccca9 to 4530985 Compare August 29, 2023 12:37
Copy link
Member

@khssnv khssnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change target branch to dev

@Raid5594 Raid5594 changed the base branch from feature/pallet-ddc-validator to dev August 30, 2023 12:56
@Raid5594 Raid5594 changed the base branch from dev to feature/pallet-ddc-validator August 30, 2023 12:56
@Raid5594 Raid5594 force-pushed the feature/remove-unused-imports branch 2 times, most recently from 8b868df to a7a1e0c Compare August 31, 2023 10:56
@Raid5594 Raid5594 changed the base branch from feature/pallet-ddc-validator to dev August 31, 2023 10:57
@Raid5594 Raid5594 merged commit ea29a42 into dev Sep 1, 2023
2 checks passed
@Raid5594 Raid5594 deleted the feature/remove-unused-imports branch September 1, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants