Implemented fetching settings from GV side #10789
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianjgeiger
requested changes
Nov 1, 2024
There was a problem hiding this comment.
This is good except for the test failure:
=========================== short test summary info ============================
FAILED osf_tests/test_gv_utils.py::TestEphemeralSettings::test_make_ephemeral_node_settings -
requests.exceptions.ConnectTimeout: HTTPConnectionPool(host='192.168.168.167', port=8004):
Max retries exceeded with url: /v1/configured-storage-addons/1/waterbutler-credentials (Caused by
ConnectTimeoutError(<urllib3.connection.HTTPConnection object at 0x7f2e40906900>,
'Connection to 192.168.168.167 timed out. (connect timeout=None)'))
=== 1 failed, 3334 passed, 29 skipped, 23823 warnings in 1540.67s (0:25:40) ====
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Changes
QA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket