Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helper PR / Don't Merge #10752

Closed
wants to merge 2 commits into from
Closed

Helper PR / Don't Merge #10752

wants to merge 2 commits into from

Conversation

cslzchen
Copy link
Collaborator

No description provided.

@cslzchen
Fix self url for PreprintsInstitutionsRelationshipSerializer
b8e5408 
In addition, removed the superfluous 'html' link that is not
part of JSON:API specs.
@cslzchen
Fix incorrect tests
ba2cf47
@cslzchen
Copy link
Collaborator Author

Note: turns out the following test failures are local only, ignoring for now

FAILED api_tests/preprints/views/test_preprint_contributors_list.py::TestPreprintContributorCreateEmail::test_add_contributor_signal_if_preprint - KeyError: <MagicMock name='mock.update_preprint_async.s().get()' id='140699847892368'>
FAILED api_tests/preprints/views/test_preprint_contributors_list.py::TestPreprintContributorCreateEmail::test_add_unregistered_contributor_sends_email - KeyError: <MagicMock name='mock.update_preprint_async.s().get()' id='140699847892368'>
FAILED api_tests/preprints/views/test_preprint_contributors_list.py::TestPreprintContributorCreateEmail::test_add_unregistered_contributor_signal_if_preprint - KeyError: <MagicMock name='mock.update_preprint_async.s().get()' id='140699847892368'>
FAILED api_tests/preprints/views/test_preprint_contributors_list.py::TestPreprintContributorCreateEmail::test_add_unregistered_contributor_without_email_no_email - KeyError: <MagicMock name='mock.update_preprint_async.s().get()' id='140699847892368'>
FAILED api_tests/preprints/views/test_preprint_contributors_list.py::TestPreprintContributorCreateEmail::test_contributor_added_signal_not_specified - KeyError: <MagicMock name='mock.update_preprint_async.s().get()' id='140699847892368'>

FAILED api_tests/preprints/views/test_preprint_detail.py::TestPreprintUpdate::test_update_primary_file - KeyError: <MagicMock name='mock.update_preprint_async.s().get()' id='140152448499056'>
FAILED api_tests/preprints/views/test_preprint_detail.py::TestPreprintUpdate::test_cannot_set_primary_file - KeyError: <MagicMock name='mock.update_preprint_async.s().get()' id='140152448499056'>
FAILED api_tests/preprints/views/test_preprint_detail.py::TestPreprintUpdate::test_update_published - KeyError: <MagicMock name='mock.update_preprint_async.s().get()' id='140152448499056'>
FAILED api_tests/preprints/views/test_preprint_detail.py::TestPreprintUpdate::test_update_published_does_not_make_node_public - KeyError: <MagicMock name='mock.update_preprint_async.s().get()' id='140152448499056'>

@cslzchen cslzchen closed this Sep 16, 2024
@cslzchen cslzchen mentioned this pull request Sep 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cslzchen