Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENG-6197] ES6 WILL run on an ARM processor #10728

Merged
merged 6 commits into from
Sep 2, 2024
Merged

[ENG-6197] ES6 WILL run on an ARM processor #10728

merged 6 commits into from
Sep 2, 2024

Conversation

Johnetordoff
Copy link
Contributor

@Johnetordoff Johnetordoff commented Aug 29, 2024 •
edited
Loading

Purpose

Get MC's working es6 image to work with our test app.

Changes

  • set up connection with es to use docker host number
  • use ES6_URI envars correctly
  • add ARM compatible Docker image

QA Notes

Please make verification statements inspired by your code and what your code touches.

  • Verify
  • Verify

What are the areas of risk?

Any concerns/considerations/questions that development raised?

Documentation

Side Effects

Ticket

https://openscience.atlassian.net/browse/ENG-6197

@Johnetordoff Johnetordoff marked this pull request as ready for review August 29, 2024 14:00
@Johnetordoff Johnetordoff force-pushed the fix-es6-hookup branch 2 times, most recently from ecbe855 to 3c9c103 Compare August 29, 2024 14:44
@Johnetordoff Johnetordoff force-pushed the fix-es6-hookup branch 2 times, most recently from 75f7f56 to a6a53c5 Compare August 29, 2024 15:04
mfraezz
mfraezz requested changes Aug 29, 2024
View reviewed changes
docker-compose.yml Outdated Show resolved Hide resolved
mfraezz
mfraezz reviewed Aug 30, 2024
View reviewed changes
Copy link
Member

@mfraezz mfraezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small note about making the docs more useful and representative of reality, otherwise looks fine.

README-docker-compose.md Show resolved Hide resolved
@mfraezz mfraezz merged commit 2d458e9 into CenterForOpenScience:develop Sep 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfraezz mfraezz mfraezz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Johnetordoff @mfraezz