Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom screen language statements changed their implementation #179

Open
CensoredUsername opened this issue Feb 14, 2024 · 6 comments
Open

Comments

@CensoredUsername
Copy link
Owner

Now they appear as a SLCustomUse node.

@madeddy
Copy link
Contributor

madeddy commented Feb 14, 2024

Wow.They're four years in and AFAIK never appeared anywhere. At least as a error src. Are they never used or slipped simply somehow through the decompiler?

If i get this from the Ren'Py implementation right, its similar to SLUse and could be used as template. Argumentinfo and ID is gone, but the args are in another way present and we gain a positional property?

@CensoredUsername
Copy link
Owner Author

There's not much reason to use it really. You only need them if you're doing something special in a screen that's still reasonable enough to do in a screen, yet not simple enough to just be a displayable.

No reason to work on that until there's a test case.

@CensoredUsername
Copy link
Owner Author

Applicable to both 7.5 and 8.0.

@madeddy
Copy link
Contributor

madeddy commented Feb 18, 2024

I add this small cosmetic/clean code issue here, because its related to print_use method in SL2:

Do we need the second arginfo call there? IMHO there should be just the "args" var from the first call passed in. Or do i make another mistake?

@CensoredUsername
Copy link
Owner Author

Nah you're correct. Seems like the first call is just unnecessary. Minor perf fix.

@CensoredUsername
Copy link
Owner Author

I add this small cosmetic/clean code issue here, because its related to print_use method in SL2:

Do we need the second arginfo call there? IMHO there should be just the "args" var from the first call passed in. Or do i make another mistake?

Fixed in 4a1ac8f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants