Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wandb logging support to Trainer class #166

Merged
merged 6 commits into from
Jun 13, 2024
Merged

Add wandb logging support to Trainer class #166

merged 6 commits into from
Jun 13, 2024

Conversation

janosh
Copy link
Collaborator

@janosh janosh commented Jun 12, 2024

@BowenD-UCB let me know if you'd like to review this

here's the run metadata that's recorded by default

Screenshot 2024-06-12 at 18 55 50

@janosh janosh added enhancement New feature or request ux User experience training Questions and issues about training the model labels Jun 12, 2024
@BowenD-UCB
Copy link
Collaborator

Thanks for the implementation!
I can take a look into the wandb logger later, I assume it's already working well on your side?
Is it possible to add some test to this?

@janosh
Copy link
Collaborator Author

janosh commented Jun 13, 2024

I can take a look into the wandb logger later, I assume it's already working well on your side?

yes

Is it possible to add some test to this?

i did in e7ef618. happy to add more if we can think of good tests.

EDIT: extended the test coverage to extra_run_config in bc87fd0

…to specify run params like batch_size that aren't already recorded by the trainer_args dict
@janosh janosh merged commit 9717a32 into main Jun 13, 2024
10 checks passed
@janosh janosh deleted the wandb branch June 13, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request training Questions and issues about training the model ux User experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants