Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ethanol amount correlates linearly with heating time -> auto heating time determination? #54

Open
rekumar opened this issue Mar 2, 2023 · 2 comments
Open

Ethanol amount correlates linearly with heating time -> auto heating time determination? #54

rekumar opened this issue Mar 2, 2023 · 2 comments
Labels
feature request new feature to implement

Comments

@rekumar
Copy link
Collaborator

rekumar commented Mar 2, 2023

No description provided.

@rekumar rekumar self-assigned this Mar 2, 2023
@rekumar
Copy link
Collaborator Author

rekumar commented Mar 2, 2023 •
edited
Loading

This is already implemented in

alab_control/alab_control/labman/components.py

Line 55 in e48ff21

heating_duration_s = heating_duration_s or self.ethanol_volume * (
.

I assumed 90 minutes per 10 mL of ethanol. Feel free to update this if you have a better ratio

@bernardusrendy
Copy link
Collaborator

Implemented. However, might be better if there is a lower bound for minimum heating time if it is not explicitly defined.

@bernardusrendy bernardusrendy added the feature request new feature to implement label Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request new feature to implement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bernardusrendy @rekumar